classification
Title: Fix and improve tests for the uu module
Type: behavior Stage: resolved
Components: Tests Versions: Python 3.8, Python 3.7, Python 3.6, Python 2.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: serhiy.storchaka Nosy List: serhiy.storchaka
Priority: normal Keywords: patch

Created on 2018-06-03 09:18 by serhiy.storchaka, last changed 2018-06-03 16:32 by serhiy.storchaka. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 7350 merged serhiy.storchaka, 2018-06-03 09:20
PR 7352 merged miss-islington, 2018-06-03 14:22
PR 7353 merged miss-islington, 2018-06-03 14:23
PR 7354 merged serhiy.storchaka, 2018-06-03 14:45
Messages (5)
msg318530 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2018-06-03 09:18
Separate tests in test_uu leak files of depend on the file leaked in other tests.

$ ./python -m test -m test_decode test_uu 
...
Warning -- files was modified by test_uu
  Before: []
  After:  ['@test_12637_tmpi'] 
test_uu failed (env changed)

$ ./python -m test -m test_decode_filename test_uu
...
Warning -- files was modified by test_uu
  Before: []
  After:  ['@test_12627_tmpi'] 
test_uu failed (env changed)

$ ./python -m test -m test_decodetwice test_uu
...
test test_uu failed -- Traceback (most recent call last):
  File "/home/serhiy/py/cpython/Lib/test/test_uu.py", line 263, in test_decodetwice
    f = open(self.tmpin, 'rb')
FileNotFoundError: [Errno 2] No such file or directory: '@test_12622_tmpi'
msg318552 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2018-06-03 14:22
New changeset 027f95c736457f12c5713d9cf5b95ac335e583df by Serhiy Storchaka in branch 'master':
bpo-33744: Fix test_uu. (GH-7350)
https://github.com/python/cpython/commit/027f95c736457f12c5713d9cf5b95ac335e583df
msg318557 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2018-06-03 15:22
New changeset da7f8ce21adc6cd0d7f86f5784a1d477891976f7 by Serhiy Storchaka (Miss Islington (bot)) in branch '3.6':
bpo-33744: Fix test_uu. (GH-7350) (GH-7353)
https://github.com/python/cpython/commit/da7f8ce21adc6cd0d7f86f5784a1d477891976f7
msg318558 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2018-06-03 15:23
New changeset ad4c7954df11b45ab2d17eefeb42bb7385615697 by Serhiy Storchaka (Miss Islington (bot)) in branch '3.7':
bpo-33744: Fix test_uu. (GH-7350) (GH-7352)
https://github.com/python/cpython/commit/ad4c7954df11b45ab2d17eefeb42bb7385615697
msg318571 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2018-06-03 16:31
New changeset 9b5c9488c77aeaddeafa7e2302bdc87dd77ac084 by Serhiy Storchaka in branch '2.7':
[2.7] bpo-33744: Fix test_uu. (GH-7350) (GH-7354)
https://github.com/python/cpython/commit/9b5c9488c77aeaddeafa7e2302bdc87dd77ac084
History
Date User Action Args
2018-06-03 16:32:14serhiy.storchakasetstatus: open -> closed
resolution: fixed
stage: patch review -> resolved
2018-06-03 16:31:55serhiy.storchakasetmessages: + msg318571
2018-06-03 15:23:56serhiy.storchakasetmessages: + msg318558
2018-06-03 15:22:57serhiy.storchakasetmessages: + msg318557
2018-06-03 14:45:53serhiy.storchakasetpull_requests: + pull_request6981
2018-06-03 14:23:51miss-islingtonsetpull_requests: + pull_request6980
2018-06-03 14:22:58miss-islingtonsetpull_requests: + pull_request6979
2018-06-03 14:22:44serhiy.storchakasetmessages: + msg318552
2018-06-03 09:20:24serhiy.storchakasetkeywords: + patch
stage: patch review
pull_requests: + pull_request6977
2018-06-03 09:18:11serhiy.storchakacreate