classification
Title: xmlbuilder's `_AsyncDeprecatedProperty` make no sens now that async is a keyword.
Type: Stage: resolved
Components: Library (Lib), XML Versions: Python 3.8, Python 3.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: mbussonn, serhiy.storchaka
Priority: normal Keywords: patch

Created on 2018-05-16 21:33 by mbussonn, last changed 2018-05-17 09:02 by serhiy.storchaka. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 6924 merged mbussonn, 2018-05-16 22:01
PR 6929 merged miss-islington, 2018-05-17 08:16
Messages (4)
msg316871 - (view) Author: Matthias Bussonnier (mbussonn) * Date: 2018-05-16 21:33
`Lib/xml/dom/xmlbuilder's DocumentLS try to catch the use of `obj.asyc` and warn that it's now `obj.async_`. Though now that async is a proper keyword `obj.async` is anyway SyntaxError, so the warning will likely almost never be displayed. I guess one could still use getattr/setattr, but I doubt this is the most common use case this was meant to prevent.
msg316897 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2018-05-17 08:16
New changeset f90f5d5c1d95721e0ca0b1c302e3d13ed34753a8 by Serhiy Storchaka (Matthias Bussonnier) in branch 'master':
bpo-33549: Remove shim and deprecation warning to access DocumentLS.async. (GH-6924)
https://github.com/python/cpython/commit/f90f5d5c1d95721e0ca0b1c302e3d13ed34753a8
msg316898 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2018-05-17 09:01
New changeset 216a27766fab59f4dfecfae0c453f7f3fd478989 by Serhiy Storchaka (Miss Islington (bot)) in branch '3.7':
bpo-33549: Remove shim and deprecation warning to access DocumentLS.async. (GH-6924) (GH-6929)
https://github.com/python/cpython/commit/216a27766fab59f4dfecfae0c453f7f3fd478989
msg316899 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2018-05-17 09:02
Thank you Matthias!
History
Date User Action Args
2018-05-17 09:02:08serhiy.storchakasetstatus: open -> closed
resolution: fixed
messages: + msg316899

stage: patch review -> resolved
2018-05-17 09:01:04serhiy.storchakasetmessages: + msg316898
2018-05-17 08:16:22miss-islingtonsetpull_requests: + pull_request6600
2018-05-17 08:16:15serhiy.storchakasetnosy: + serhiy.storchaka
messages: + msg316897
2018-05-17 08:15:45serhiy.storchakasetcomponents: + Library (Lib), XML
versions: + Python 3.7, Python 3.8
2018-05-16 22:01:12mbussonnsetkeywords: + patch
stage: patch review
pull_requests: + pull_request6594
2018-05-16 21:33:46mbussonncreate