classification
Title: dataclasses.make_dataclass does not validate fields for being valid identifiers
Type: behavior Stage: resolved
Components: Versions: Python 3.8, Python 3.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: eric.smith Nosy List: eric.smith, miss-islington, ned.deily
Priority: Keywords: patch

Created on 2018-05-16 12:27 by eric.smith, last changed 2018-05-16 18:00 by eric.smith. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 6906 merged eric.smith, 2018-05-16 14:19
PR 6908 merged miss-islington, 2018-05-16 15:32
Messages (3)
msg316803 - (view) Author: Eric V. Smith (eric.smith) * (Python committer) Date: 2018-05-16 13:15
I'm going to make this a release blocker, since it's basically a code injection vector, although I know of no way to exploit it. The fix is easy enough.
msg316819 - (view) Author: Eric V. Smith (eric.smith) * (Python committer) Date: 2018-05-16 15:31
New changeset 4e81296b1874829912c687eba4d39361ab51e145 by Eric V. Smith in branch 'master':
bpo-33536: Validate make_dataclass() field names. (GH-6906)
https://github.com/python/cpython/commit/4e81296b1874829912c687eba4d39361ab51e145
msg316836 - (view) Author: miss-islington (miss-islington) Date: 2018-05-16 16:28
New changeset 6409e759df0654f4a081eb4a50aadde995382043 by Miss Islington (bot) in branch '3.7':
bpo-33536: Validate make_dataclass() field names. (GH-6906)
https://github.com/python/cpython/commit/6409e759df0654f4a081eb4a50aadde995382043
History
Date User Action Args
2018-05-16 18:00:50eric.smithsetpriority: release blocker ->
status: open -> closed
resolution: fixed
stage: patch review -> resolved
2018-05-16 16:28:24miss-islingtonsetnosy: + miss-islington
messages: + msg316836
2018-05-16 15:32:44miss-islingtonsetpull_requests: + pull_request6576
2018-05-16 15:31:32eric.smithsetmessages: + msg316819
2018-05-16 14:19:20eric.smithsetkeywords: + patch
stage: patch review
pull_requests: + pull_request6574
2018-05-16 13:15:51eric.smithsetpriority: high -> release blocker
nosy: + ned.deily
messages: + msg316803

2018-05-16 12:27:58eric.smithcreate