Title: dataclasses: unneeded test in _is_classvar
Type: behavior Stage: resolved
Components: Library (Lib) Versions: Python 3.8, Python 3.7
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: eric.smith Nosy List: eric.smith, miss-islington, ned.deily
Priority: Keywords: patch

Created on 2018-05-16 08:04 by eric.smith, last changed 2018-05-16 11:56 by eric.smith. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 6897 merged eric.smith, 2018-05-16 09:26
PR 6899 merged miss-islington, 2018-05-16 11:25
Messages (3)
msg316779 - (view) Author: Eric V. Smith (eric.smith) * (Python committer) Date: 2018-05-16 08:04
There's an unnecessary test for "if typing" in _is_classvar. I added this function yesterday, and due to some refactoring it picked up some superfluous text. I'm going to remove it.
msg316797 - (view) Author: Eric V. Smith (eric.smith) * (Python committer) Date: 2018-05-16 11:24
New changeset 9285835a05ad0319acef111340266c0f85ed549c by Eric V. Smith in branch 'master':
bpo-33534: Remove unneeded test. (GH-6897)
msg316800 - (view) Author: miss-islington (miss-islington) Date: 2018-05-16 11:46
New changeset 8e20fc388f1f1e6b2b38bf11995322c274b4d43a by Miss Islington (bot) in branch '3.7':
bpo-33534: Remove unneeded test. (GH-6897)
Date User Action Args
2018-05-16 11:56:09eric.smithsetpriority: release blocker ->
status: open -> closed
resolution: fixed
stage: patch review -> resolved
2018-05-16 11:46:39miss-islingtonsetnosy: + miss-islington
messages: + msg316800
2018-05-16 11:25:16miss-islingtonsetpull_requests: + pull_request6569
2018-05-16 11:24:10eric.smithsetmessages: + msg316797
2018-05-16 09:26:32eric.smithsetkeywords: + patch
stage: patch review
pull_requests: + pull_request6567
2018-05-16 08:04:01eric.smithcreate