classification
Title: github pull request template does not satisfy markdownlint
Type: enhancement Stage: resolved
Components: Documentation Versions:
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: docs@python Nosy List: benjamin.peterson, docs@python, eitan.adler
Priority: normal Keywords: patch

Created on 2018-05-14 00:40 by eitan.adler, last changed 2018-05-14 01:27 by benjamin.peterson. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 6786 merged eitan.adler, 2018-05-14 00:41
PR 6787 merged benjamin.peterson, 2018-05-14 00:59
Messages (3)
msg316484 - (view) Author: Eitan Adler (eitan.adler) * Date: 2018-05-14 00:40
markdownlint is, as the name implies, a tool for linting markdown files.

The current template has the following lint warnings:

```
./.github/PULL_REQUEST_TEMPLATE.md:8: MD031 Fenced code blocks should be surrounded by blank lines
./.github/PULL_REQUEST_TEMPLATE.md:10: MD031 Fenced code blocks should be surrounded by blank lines
./.github/PULL_REQUEST_TEMPLATE.md:19: MD031 Fenced code blocks should be surrounded by blank lines
./.github/PULL_REQUEST_TEMPLATE.md:21: MD031 Fenced code blocks should be surrounded by blank lines
```

These should be fixed
msg316486 - (view) Author: Benjamin Peterson (benjamin.peterson) * (Python committer) Date: 2018-05-14 00:55
New changeset 5cd22cf2097a6dd209999cf97858d54564a3be87 by Benjamin Peterson (Eitan Adler) in branch 'master':
bpo-33488: Satisfy markdownlint for the pull request template. (GH-6786)
https://github.com/python/cpython/commit/5cd22cf2097a6dd209999cf97858d54564a3be87
msg316488 - (view) Author: Benjamin Peterson (benjamin.peterson) * (Python committer) Date: 2018-05-14 01:27
New changeset f1ee4a2e52d98698ec2c0a0e8acb6cd3bbc9bf1f by Benjamin Peterson in branch '3.7':
[3.7] bpo-33488: Satisfy markdownlint for the pull request template. (GH-6786)
https://github.com/python/cpython/commit/f1ee4a2e52d98698ec2c0a0e8acb6cd3bbc9bf1f
History
Date User Action Args
2018-05-14 01:27:00benjamin.petersonsetmessages: + msg316488
2018-05-14 00:59:52benjamin.petersonsetpull_requests: + pull_request6474
2018-05-14 00:56:28benjamin.petersonsetstatus: open -> closed
resolution: fixed
stage: patch review -> resolved
2018-05-14 00:55:38benjamin.petersonsetnosy: + benjamin.peterson
messages: + msg316486
2018-05-14 00:41:11eitan.adlersetkeywords: + patch
stage: patch review
pull_requests: + pull_request6473
2018-05-14 00:40:40eitan.adlercreate