Title: build system requires explicit compiler, but should discover it
Type: compile error Stage: resolved
Components: Build Versions:
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: benjamin.peterson, eitan.adler, iritkatriel, matrixise
Priority: normal Keywords: patch

Created on 2018-05-13 18:28 by eitan.adler, last changed 2020-10-16 18:45 by benjamin.peterson. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 6780 merged eitan.adler, 2018-05-13 18:31
Messages (5)
msg316468 - (view) Author: Eitan Adler (eitan.adler) * Date: 2018-05-13 18:28 requires explicit configuration for finding the preferred compiler. This results in a non-native way of configuring the system, and does not actually work on most platforms.

Expected behavior:

CC is used to discover the C compiler; CPP, LD, CXX, etc. are used to discover their appropriate tools

--without-gcc or --with-icc must be explicitly passed
msg316569 - (view) Author: St├ęphane Wirtel (matrixise) * (Python committer) Date: 2018-05-14 19:55
Do you have an example where your patch will work and not the current Thank you.
msg316585 - (view) Author: Eitan Adler (eitan.adler) * Date: 2018-05-14 21:44
On any system where "gcc" is not the correct compiler to use.  If it does not exist, is too old, points to the incorrect compiler, etc.

Concretely I have two such systems:
- on one, "gcc" does not exist
- on the other "gcc" is actually a hardlink to "clang"
msg316617 - (view) Author: Benjamin Peterson (benjamin.peterson) * (Python committer) Date: 2018-05-15 03:55
New changeset 98929b545e86e7c7296c912d8f34e8e8d3fd6439 by Benjamin Peterson (Eitan Adler) in branch 'master':
bpo-33483: more correctly handle finding the C compiler (GH-6780)
msg378733 - (view) Author: Irit Katriel (iritkatriel) * (Python committer) Date: 2020-10-16 18:42
This seems complete, can it be closed?
Date User Action Args
2020-10-16 18:45:11benjamin.petersonsetstatus: open -> closed
resolution: fixed
stage: patch review -> resolved
2020-10-16 18:42:02iritkatrielsetnosy: + iritkatriel
messages: + msg378733
2018-05-15 03:55:43benjamin.petersonsetnosy: + benjamin.peterson
messages: + msg316617
2018-05-14 21:44:49eitan.adlersetmessages: + msg316585
2018-05-14 19:55:11matrixisesetnosy: + matrixise
messages: + msg316569
2018-05-13 18:31:39eitan.adlersetkeywords: + patch
stage: patch review
pull_requests: + pull_request6466
2018-05-13 18:28:54eitan.adlercreate