Title: Upgrade to pip 10 for Python 3.7
Type: enhancement Stage: resolved
Components: Versions: Python 3.8, Python 3.7, Python 3.6, Python 2.7
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: paul.moore Nosy List: Marcus.Smith, dstufft, miss-islington, ncoghlan, ned.deily, paul.moore, serhiy.storchaka
Priority: deferred blocker Keywords: patch

Created on 2018-03-24 07:27 by ncoghlan, last changed 2018-04-21 04:58 by ncoghlan. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 6546 merged paul.moore, 2018-04-20 15:02
PR 6550 merged miss-islington, 2018-04-20 20:07
PR 6551 merged miss-islington, 2018-04-20 20:08
PR 6553 merged miss-islington, 2018-04-20 20:22
Messages (16)
msg314360 - (view) Author: Nick Coghlan (ncoghlan) * (Python committer) Date: 2018-03-24 07:27
Paul brought up recently [1] that with pip 10.0.0 due for release next month [2], we'd really prefer to ship that in Python 3.7.0 (such that 3.7 launches with PEP 518/517 pyproject.toml support), rather than shipping with 9.0.x and then upgrading to 10.0.0 in Python 3.7.1.

The timing is such that 10.0.0 won't quite be ready for 3.7.0b3, but it should be released before 3.7.0b4 at the end of April.

msg314361 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2018-03-24 07:35
Currently the repository contains blobs for pip and setuptools (2 MB total) which are updated with every release of pip and setuptools. This increases the size of the repository by 2 MB several times per year. Wouldn't be better to put them in a separate repository like Tcl/Tk?
msg314362 - (view) Author: Nick Coghlan (ncoghlan) * (Python committer) Date: 2018-03-24 07:40
Possibly - we implemented ensurepip the way we did just because it was the easiest option, not because we closely considered all the available approaches.

That would be a separate process improvement issue, though :)
msg314577 - (view) Author: Ned Deily (ned.deily) * (Python committer) Date: 2018-03-28 09:01
BTW, when updating the bundled wheels, please remember to use an issue (like this one) and include a NEWS entry using blurb; in other words, don't use the "skip news" label on PRs.  That way the change will be documented in the Misc/NEWS and docs changelog.html for the release(s).  See, for example, Issue33163, which added NEWS entries after the fact.  Thanks!
msg314622 - (view) Author: Donald Stufft (dstufft) * (Python committer) Date: 2018-03-28 22:44
Oh, I had never written NEWS entries for upgrading pip/setuptools, with the idea that the specific version being installed is considered an implementation detail. However if folks want it, I can.
msg314629 - (view) Author: Nick Coghlan (ncoghlan) * (Python committer) Date: 2018-03-29 01:55
It's a useful data point for folks trying to diagnose post-maintenance-update failures when we upgrade pip on their behalf, rather than them explicitly doing it themselves.
msg314634 - (view) Author: Ned Deily (ned.deily) * (Python committer) Date: 2018-03-29 07:00
The changelog for a release is our primary notification to users about what has changed in a Python release.  With 3.6.5, we just had a case where it seemed important to update pip between the release candidate and the final, something we normally would not do.  In the past, we could manually munge the changelog to include this info but it's much more difficult to do so now with the NEWS entries managed via blurb.  In fact, IIRC, it was a design decision to require a b.p.o issue for any item meriting a NEWS item.  So, it's a bit of extra work for you all but it does make life a lot easier for the release team as it's a lot easier to add the NEWS item at the time when the updates are checked in rather than having to go back and do it after the fact. Thanks!
msg315314 - (view) Author: Paul Moore (paul.moore) * (Python committer) Date: 2018-04-15 10:33
Pip 10 has now been released. I'll be getting a PR to put it into 3.7 in the next few days. One question on workflow - is the right approach to create a PR for master and request a backport to the 3.7 branch? Or is there something else I should do?

Also, can I just check the timing implications should we need to do a 10.0.1 followup release? Would we need to have that released in time for b4, or would it be acceptable to update to 10.0.1 between b4 and rc1? (I'm not trying to push for any particular decision here - we may not even need a 10.0.1 - just want to be sure of the rules).
msg315315 - (view) Author: Nick Coghlan (ncoghlan) * (Python committer) Date: 2018-04-15 11:05
Merge to master and set the "needs backport to 3.7" label for the initial PR - the backport bot will then take care of creating the 3.7 PR. For the backport, all you then need to do is leave an Approve review, and the bot will automatically merge it once the CI completes.

I'll defer to Ned regarding post-b4 updates, but I'd expect them to be fine if needed - otherwise we wouldn't be able to respond to any pip bugs reported against b4.
msg315316 - (view) Author: Paul Moore (paul.moore) * (Python committer) Date: 2018-04-15 11:19
Thanks Nick, that's what I thought for the workflow. And agreed with your understanding of the post-b4 question, but as you say Ned's the boss on that one :-)
msg315321 - (view) Author: Ned Deily (ned.deily) * (Python committer) Date: 2018-04-15 13:43
The ensurepip blob is a bit of a special case regarding updates, that is, I think we can be a little more flexible about them since they are getting tested and a lot of exposure external to Python releases.  Accepting a bugfix update for pip between 3.7.0b4 and 3.7.0rc1 should be OK although the closer it is to the b4 date, rather than the rc1 date, the happier I would be :)
msg315532 - (view) Author: Paul Moore (paul.moore) * (Python committer) Date: 2018-04-20 20:06
New changeset 0399cf9b5e370516e3d0aed6a63ff74aff5eadb5 by Paul Moore in branch 'master':
bpo-33131: Upgrade ensurepip to bundle pip 10.0.1 (GH-6546)
msg315533 - (view) Author: Ned Deily (ned.deily) * (Python committer) Date: 2018-04-20 20:15
Since 2.7 was upgraded, I think 3.6.x should be upgraded to 10.0.x, as well.
msg315537 - (view) Author: miss-islington (miss-islington) Date: 2018-04-20 20:47
New changeset b221107d32370670905fefb569b3104748f92afe by Miss Islington (bot) in branch '3.7':
bpo-33131: Upgrade ensurepip to bundle pip 10.0.1 (GH-6546)
msg315538 - (view) Author: miss-islington (miss-islington) Date: 2018-04-20 20:48
New changeset 4caba7a94024d8af2eed26300f13ff4433dcb05b by Miss Islington (bot) in branch '2.7':
bpo-33131: Upgrade ensurepip to bundle pip 10.0.1 (GH-6546)
msg315541 - (view) Author: miss-islington (miss-islington) Date: 2018-04-20 22:03
New changeset 47d57bfd3d6ceb08f98fcff14fe3c8bb41ca0664 by Miss Islington (bot) in branch '3.6':
bpo-33131: Upgrade ensurepip to bundle pip 10.0.1 (GH-6546)
Date User Action Args
2018-04-21 04:58:22ncoghlansetstatus: open -> closed
assignee: paul.moore
resolution: fixed
stage: patch review -> resolved
2018-04-20 22:03:01miss-islingtonsetmessages: + msg315541
2018-04-20 20:48:46miss-islingtonsetmessages: + msg315538
2018-04-20 20:47:54miss-islingtonsetnosy: + miss-islington
messages: + msg315537
2018-04-20 20:22:38miss-islingtonsetpull_requests: + pull_request6249
2018-04-20 20:15:10ned.deilysetmessages: + msg315533
versions: + Python 2.7, Python 3.6
2018-04-20 20:08:02miss-islingtonsetpull_requests: + pull_request6248
2018-04-20 20:07:07miss-islingtonsetpull_requests: + pull_request6247
2018-04-20 20:06:54paul.mooresetmessages: + msg315532
2018-04-20 15:02:53paul.mooresetkeywords: + patch
stage: needs patch -> patch review
pull_requests: + pull_request6243
2018-04-15 13:43:06ned.deilysetmessages: + msg315321
2018-04-15 11:19:41paul.mooresetmessages: + msg315316
2018-04-15 11:05:56ncoghlansetmessages: + msg315315
2018-04-15 10:33:38paul.mooresetmessages: + msg315314
2018-03-29 07:00:37ned.deilysetmessages: + msg314634
2018-03-29 01:55:36ncoghlansetmessages: + msg314629
2018-03-28 22:44:03dstufftsetmessages: + msg314622
2018-03-28 09:01:09ned.deilysetmessages: + msg314577
2018-03-24 07:40:51ncoghlansetmessages: + msg314362
2018-03-24 07:35:44serhiy.storchakasetnosy: + serhiy.storchaka
messages: + msg314361
2018-03-24 07:27:41ncoghlancreate