classification
Title: test_hashlib fails if _md5 is not built
Type: Stage: resolved
Components: Build Versions: Python 3.7, Python 3.6
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: benjamin.peterson
Priority: normal Keywords: patch

Created on 2018-01-30 05:29 by benjamin.peterson, last changed 2018-01-30 07:01 by benjamin.peterson. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 5441 merged benjamin.peterson, 2018-01-30 05:31
PR 5442 merged miss-islington, 2018-01-30 06:14
Messages (3)
msg311233 - (view) Author: Benjamin Peterson (benjamin.peterson) * (Python committer) Date: 2018-01-30 05:29
$ make
$ rm build/lib.linux-x86_64-3.7/_md5.cpython-37m-x86_64-linux-gnu.so 
$ ./python -m test test_hashlib
Run tests sequentially
0:00:00 load avg: 1.11 [1/1] test_hashlib
ERROR:root:code for hash md5 was not found.
Traceback (most recent call last):
  File "/home/benjamin/dev/python/cpython/Lib/hashlib.py", line 243, in <module>
    globals()[__func_name] = __get_hash(__func_name)
  File "/home/benjamin/dev/python/cpython/Lib/hashlib.py", line 113, in __get_builtin_constructor
    raise ValueError('unsupported hash type ' + name)
ValueError: unsupported hash type md5
/home/benjamin/dev/python/cpython/Lib/test/test_hashlib.py:90: UserWarning: Did a C extension fail to compile? No module named '_md5'
  warnings.warn('Did a C extension fail to compile? %s' % error)
Warning -- logging._handlerList was modified by test_hashlib
  Before: (139817255081928, [<weakref at 0x7f29bdc02868; to '_StderrHandler' at 0x7f29bdbfeb70>, <weakref at 0x7f29ba4f71d8; to 'StreamHandler' at 0x7f29ba4ee8d0>], [<weakref at 0x7f29bdc02868; to '_StderrHandler' at 0x7f29bdbfeb70>])
  After:  (139817255081928, [<weakref at 0x7f29bdc02868; to '_StderrHandler' at 0x7f29bdbfeb70>, <weakref at 0x7f29ba4f71d8; to 'StreamHandler' at 0x7f29ba4ee8d0>], [<weakref at 0x7f29bdc02868; to '_StderrHandler' at 0x7f29bdbfeb70>, <weakref at 0x7f29ba4f71d8; to 'StreamHandler' at 0x7f29ba4ee8d0>]) 
test test_hashlib failed -- Traceback (most recent call last):
  File "/home/benjamin/dev/python/cpython/Lib/test/test_hashlib.py", line 209, in test_get_builtin_constructor
    constructor = get_builtin_constructor('md5')
  File "/home/benjamin/dev/python/cpython/Lib/hashlib.py", line 113, in __get_builtin_constructor
    raise ValueError('unsupported hash type ' + name)
ValueError: unsupported hash type md5

test_hashlib failed

1 test failed:
    test_hashlib

Total duration: 397 ms
Tests result: FAILURE
msg311241 - (view) Author: Benjamin Peterson (benjamin.peterson) * (Python committer) Date: 2018-01-30 06:14
New changeset 95441809ef77a8df5e14601ade6c054ef7114c02 by Benjamin Peterson in branch 'master':
closes bpo-32721: do not fail test_hashlib if _md5 isn't available (GH-5441)
https://github.com/python/cpython/commit/95441809ef77a8df5e14601ade6c054ef7114c02
msg311245 - (view) Author: Benjamin Peterson (benjamin.peterson) * (Python committer) Date: 2018-01-30 07:01
New changeset 6b2bbcc4cca414f35f67caa4674f59f41ff638ea by Benjamin Peterson (Miss Islington (bot)) in branch '3.6':
closes bpo-32721: do not fail test_hashlib if _md5 isn't available (GH-5441) (GH-5442)
https://github.com/python/cpython/commit/6b2bbcc4cca414f35f67caa4674f59f41ff638ea
History
Date User Action Args
2018-01-30 07:01:34benjamin.petersonsetmessages: + msg311245
2018-01-30 06:14:36miss-islingtonsetpull_requests: + pull_request5274
2018-01-30 06:14:20benjamin.petersonsetstatus: open -> closed
resolution: fixed
messages: + msg311241

stage: patch review -> resolved
2018-01-30 05:31:53benjamin.petersonsetkeywords: + patch
stage: patch review
pull_requests: + pull_request5273
2018-01-30 05:29:15benjamin.petersoncreate