➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2017-12-18 19:23 by izbyshev, last changed 2022-04-11 14:58 by admin. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 4920 | merged | izbyshev, 2017-12-18 19:33 | |
| Messages (2) | |||
|---|---|---|---|
| msg308581 - (view) | Author: Alexey Izbyshev (izbyshev) *  |
Date: 2017-12-18 19:23 | |
The last part of test_close_fds() doesn't match its own comment. The following assertion always holds because fds_to_keep and open_fds are disjoint by construction.
self.assertFalse(remaining_fds & fds_to_keep & open_fds,
"Some fds not in pass_fds were left open")
|
|||
| msg308582 - (view) | Author: Gregory P. Smith (gregory.p.smith) *  |
Date: 2017-12-18 20:26 | |
New changeset 2d8f06382e7d5a759ca554110a699a397114824a by Gregory P. Smith (izbyshev) in branch 'master': bpo-32369: test_subprocess: Fix pass_fds check in test_close_fds() (#4920) https://github.com/python/cpython/commit/2d8f06382e7d5a759ca554110a699a397114824a |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:58:55 | admin | set | github: 76550 |
| 2017-12-18 22:34:22 | izbyshev | set | status: open -> closed resolution: fixed stage: patch review -> resolved |
| 2017-12-18 20:26:53 | gregory.p.smith | set | messages: + msg308582 |
| 2017-12-18 19:33:32 | izbyshev | set | keywords:
+ patch stage: patch review pull_requests: + pull_request4815 |
| 2017-12-18 19:28:31 | izbyshev | set | nosy:
+ gregory.p.smith, pitrou |
| 2017-12-18 19:23:30 | izbyshev | create | |