classification
Title: Pass keyword arguments from dataclasses.make_dataclass() to @dataclass.
Type: behavior Stage: resolved
Components: Library (Lib) Versions: Python 3.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: eric.smith Nosy List: eric.smith, levkivskyi, rhettinger
Priority: normal Keywords: patch

Created on 2017-12-11 19:58 by eric.smith, last changed 2018-01-06 22:14 by eric.smith. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 5116 closed eric.smith, 2018-01-06 21:48
PR 5117 merged eric.smith, 2018-01-06 21:51
Messages (2)
msg308074 - (view) Author: Eric V. Smith (eric.smith) * (Python committer) Date: 2017-12-11 19:58
make_dataclass() should take optional keyword only arguments and pass them to @dataclass() when it uses it after it creates a new class.

The parameters are:
init=True, repr=True, eq=True, order=False, hash=None, frozen=False

Obviously, these should reflect their default values in @dataclass, should that ever change.
msg309583 - (view) Author: Eric V. Smith (eric.smith) * (Python committer) Date: 2018-01-06 22:10
New changeset d80b443f02e087dd289ffefd04179c675304d76d by Eric V. Smith in branch 'master':
 bpo-32279: Add additional params to make_dataclass(), pass through to dataclass(). (gh-5117)
https://github.com/python/cpython/commit/d80b443f02e087dd289ffefd04179c675304d76d
History
Date User Action Args
2018-01-06 22:14:16eric.smithsetstatus: open -> closed
type: behavior
resolution: fixed
stage: patch review -> resolved
2018-01-06 22:10:00eric.smithsetmessages: + msg309583
2018-01-06 21:51:32eric.smithsetpull_requests: + pull_request4983
2018-01-06 21:48:16eric.smithsetkeywords: + patch
stage: patch review
pull_requests: + pull_request4982
2017-12-11 19:58:58eric.smithcreate