This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Make patchcheck.py work for out-of-tree builds
Type: enhancement Stage: resolved
Components: Versions: Python 3.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: belopolsky, eric.araujo, izbyshev, miss-islington, vstinner
Priority: normal Keywords: patch

Created on 2017-12-09 01:35 by izbyshev, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 4760 merged izbyshev, 2017-12-09 01:49
PR 9992 merged miss-islington, 2018-10-20 00:49
PR 9993 merged miss-islington, 2018-10-20 00:50
Messages (7)
msg307875 - (view) Author: Alexey Izbyshev (izbyshev) * (Python triager) Date: 2017-12-09 01:35
Despite some steps made in issue 9860 make patchcheck still doesn't work for out-of-tree builds because it runs git and hg in the current directory instead of the source directory (msg169465).
msg310675 - (view) Author: Alexey Izbyshev (izbyshev) * (Python triager) Date: 2018-01-25 13:47
Any objections to the PR?
msg328115 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2018-10-20 00:49
New changeset aa95bfb5fee366aa58c90b7e1c77fc7e183dbf3a by Victor Stinner (Alexey Izbyshev) in branch 'master':
bpo-32256: Make patchcheck.py work for out-of-tree builds (GH-4760)
https://github.com/python/cpython/commit/aa95bfb5fee366aa58c90b7e1c77fc7e183dbf3a
msg328119 - (view) Author: miss-islington (miss-islington) Date: 2018-10-20 01:21
New changeset 1662bbf09fade0310d03736066e5c36611bb4b9b by Miss Islington (bot) in branch '3.7':
bpo-32256: Make patchcheck.py work for out-of-tree builds (GH-4760)
https://github.com/python/cpython/commit/1662bbf09fade0310d03736066e5c36611bb4b9b
msg328120 - (view) Author: miss-islington (miss-islington) Date: 2018-10-20 01:25
New changeset 42c52a9e45ed6ff2867403894bc030ed5780282d by Miss Islington (bot) in branch '3.6':
bpo-32256: Make patchcheck.py work for out-of-tree builds (GH-4760)
https://github.com/python/cpython/commit/42c52a9e45ed6ff2867403894bc030ed5780282d
msg328121 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2018-10-20 01:33
Thanks Alexey Izbyshev!
msg328178 - (view) Author: Alexey Izbyshev (izbyshev) * (Python triager) Date: 2018-10-20 20:42
Thank you for testing and merging, Victor!
History
Date User Action Args
2022-04-11 14:58:55adminsetgithub: 76437
2018-10-20 20:42:50izbyshevsetstatus: open -> closed
resolution: fixed
messages: + msg328178

stage: patch review -> resolved
2018-10-20 01:33:21vstinnersetmessages: + msg328121
2018-10-20 01:25:54miss-islingtonsetmessages: + msg328120
2018-10-20 01:21:48miss-islingtonsetnosy: + miss-islington
messages: + msg328119
2018-10-20 00:50:06miss-islingtonsetpull_requests: + pull_request9334
2018-10-20 00:49:54miss-islingtonsetpull_requests: + pull_request9333
2018-10-20 00:49:46vstinnersetnosy: + vstinner
messages: + msg328115
2018-01-25 13:47:37izbyshevsetnosy: + belopolsky, eric.araujo
messages: + msg310675
2017-12-09 01:49:59izbyshevsetkeywords: + patch
stage: patch review
pull_requests: + pull_request4663
2017-12-09 01:35:58izbyshevcreate