classification
Title: [3.7 Regression] build with --with-system-libmpdec is broken
Type: compile error Stage: resolved
Components: Build Versions: Python 3.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: skrah Nosy List: doko, ned.deily, skrah, vstinner
Priority: release blocker Keywords: patch

Created on 2017-12-06 13:50 by doko, last changed 2017-12-06 17:28 by skrah. This issue is now closed.

Files
File name Uploaded Description Edit
issue32233.diff doko, 2017-12-06 13:51
Pull Requests
URL Status Linked Edit
PR 4739 merged skrah, 2017-12-06 17:09
Messages (5)
msg307738 - (view) Author: Matthias Klose (doko) * (Python committer) Date: 2017-12-06 13:50
in setup.py, for the _decimal module the libararies are now set exclusively to ['m'], without checking if this is really needed, and overriding the external mpdec library, breaking the build.  Is there any reason to override that?
msg307739 - (view) Author: Matthias Klose (doko) * (Python committer) Date: 2017-12-06 13:51
proposed patch, however I don't know the rationale for that change compared to 3.7alpha2.
msg307751 - (view) Author: Stefan Krah (skrah) * (Python committer) Date: 2017-12-06 16:42
At some point linking explicitly against libm was added. The build
still worked until 8acaa31eec removed detect_math_libs().
msg307753 - (view) Author: Stefan Krah (skrah) * (Python committer) Date: 2017-12-06 16:49
I suggest to restore the logic from 75c0d4f6bb97e723adc3a03c0ff6aaaee0c6981a .
msg307757 - (view) Author: Stefan Krah (skrah) * (Python committer) Date: 2017-12-06 17:24
New changeset bd4ed77f73d37df325fc8f1e193b3ce6bc08094d by Stefan Krah in branch 'master':
bpo-32233: Fix build with --with-system-libmpdec. (#4739)
https://github.com/python/cpython/commit/bd4ed77f73d37df325fc8f1e193b3ce6bc08094d
History
Date User Action Args
2017-12-06 17:28:18skrahsetstatus: open -> closed
assignee: skrah
type: compile error
resolution: fixed
stage: patch review -> resolved
2017-12-06 17:24:23skrahsetmessages: + msg307757
2017-12-06 17:09:58skrahsetstage: patch review
pull_requests: + pull_request4642
2017-12-06 16:49:31skrahsetmessages: + msg307753
2017-12-06 16:42:47skrahsetnosy: + skrah
messages: + msg307751
2017-12-06 16:25:13ned.deilysetpriority: normal -> release blocker
nosy: + ned.deily
2017-12-06 13:58:33vstinnersetnosy: + vstinner
2017-12-06 13:51:42dokosetfiles: + issue32233.diff
keywords: + patch
messages: + msg307739
2017-12-06 13:50:32dokocreate