➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2017-11-26 04:37 by ncoghlan, last changed 2022-04-11 14:58 by admin. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 4567 | merged | ncoghlan, 2017-11-26 07:12 | |
| Messages (6) | |||
|---|---|---|---|
| msg306988 - (view) | Author: Nick Coghlan (ncoghlan) *  |
Date: 2017-11-26 04:37 | |
We currently run the runtime embedding tests as a subsection of "test_capi". I'm thinking it may make more sense to clearly separate them out as their own CPython-only test file, "test_runtime_embedding". I'm also thinking we should add a new "Runtime embedding" entry to the experts index, with myself, Victor Stinner, Eric Snow, and Steve Dower as the initial members. |
|||
| msg306990 - (view) | Author: Nick Coghlan (ncoghlan) * |
Date: 2017-11-26 04:43 | |
As noted in https://bugs.python.org/issue32096#msg306989, it would also be good to ensure that the full traceback from a failed `_testembed` call is always visible when running in verbose mode. |
|||
| msg306996 - (view) | Author: STINNER Victor (vstinner) * |
Date: 2017-11-26 08:03 | |
What about a shorter name like test_embed? |
|||
| msg307003 - (view) | Author: Nick Coghlan (ncoghlan) * |
Date: 2017-11-26 12:04 | |
I guess the shorted name would also better match the naming scheme used for the C API test module: Modules/_testcapi.c -> Lib/test/test_capi.py Progams/_testembed.c -> Lib/test/test_embed.py |
|||
| msg307045 - (view) | Author: STINNER Victor (vstinner) * |
Date: 2017-11-27 10:55 | |
> Modules/_testcapi.c -> Lib/test/test_capi.py > Progams/_testembed.c -> Lib/test/test_embed.py I like it :-) |
|||
| msg307098 - (view) | Author: Nick Coghlan (ncoghlan) * |
Date: 2017-11-27 22:11 | |
New changeset 39f0bb5ad0715dbfc0a2d5dd6d0ddea9e4c65ae2 by Nick Coghlan in branch 'master': bpo-32136: Separate embedding tests from C API tests (GH-4567) https://github.com/python/cpython/commit/39f0bb5ad0715dbfc0a2d5dd6d0ddea9e4c65ae2 |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:58:54 | admin | set | github: 76317 |
| 2017-11-27 22:12:15 | ncoghlan | set | status: open -> closed resolution: fixed stage: patch review -> resolved |
| 2017-11-27 22:11:53 | ncoghlan | set | messages: + msg307098 |
| 2017-11-27 10:55:56 | vstinner | set | messages: + msg307045 |
| 2017-11-26 12:04:05 | ncoghlan | set | messages: + msg307003 |
| 2017-11-26 08:03:38 | vstinner | set | messages: + msg306996 |
| 2017-11-26 07:12:26 | ncoghlan | set | keywords:
+ patch stage: needs patch -> patch review pull_requests: + pull_request4495 |
| 2017-11-26 04:43:41 | ncoghlan | set | messages: + msg306990 |
| 2017-11-26 04:37:15 | ncoghlan | create | |