➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2017-08-28 18:55 by pablogsal, last changed 2022-04-11 14:58 by admin. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 3229 | merged | pablogsal, 2017-08-28 18:55 | |
| PR 3430 | merged | python-dev, 2017-09-07 20:53 | |
| Messages (4) | |||
|---|---|---|---|
| msg300960 - (view) | Author: Pablo Galindo Salgado (pablogsal) *  |
Date: 2017-08-28 18:55 | |
There are two documentation issues regarding the ZeroMQSocketListener and ZeroMQSocketHandler examples in the Logging Cookbook: The first issue is that in the 'init' method for the 'ZeroMQSocketListener' the base class 'init' is never called and therefore the internal variables are not correctly initialized. This leads to an empty 'handlers' attribute and a undefined 'queue' attribute. The second issue is that zmq.Socket.send and zmq.Socket.setsockopt only admits bytecode variables and therefore it fails in Python3 when using plain strings. |
|||
| msg301629 - (view) | Author: Christian Heimes (christian.heimes) * |
Date: 2017-09-07 20:53 | |
New changeset 586c0502b5eb9a39cabe0bc2707a8ff63114265c by Christian Heimes (Pablo Galindo) in branch 'master': bpo-31294: Fix ZeroMQSocketListener and ZeroMQSocketHandler examples (#3229) https://github.com/python/cpython/commit/586c0502b5eb9a39cabe0bc2707a8ff63114265c |
|||
| msg301641 - (view) | Author: Christian Heimes (christian.heimes) * |
Date: 2017-09-07 22:28 | |
New changeset 27ce5a1b1931b670da234c30d24bfbbc93fa24d7 by Christian Heimes (Miss Islington (bot)) in branch '3.6': [3.6] bpo-31294: Fix ZeroMQSocketListener and ZeroMQSocketHandler examples (GH-3229) (#3430) https://github.com/python/cpython/commit/27ce5a1b1931b670da234c30d24bfbbc93fa24d7 |
|||
| msg301745 - (view) | Author: Christian Heimes (christian.heimes) * |
Date: 2017-09-08 22:27 | |
Thanks for your contribution. Your PR has been merged into 3.6 and master, which will become Python 3.7 eventually. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:58:51 | admin | set | github: 75475 |
| 2017-09-08 22:27:33 | christian.heimes | set | status: open -> closed versions: + Python 3.6, Python 3.7 messages: + msg301745 resolution: fixed stage: patch review -> resolved |
| 2017-09-07 22:28:23 | christian.heimes | set | messages: + msg301641 |
| 2017-09-07 20:53:24 | python-dev | set | keywords:
+ patch stage: patch review pull_requests: + pull_request3427 |
| 2017-09-07 20:53:14 | christian.heimes | set | nosy:
+ christian.heimes messages: + msg301629 |
| 2017-08-28 18:55:35 | pablogsal | create | |