This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Title: Sort only when needed in TimedRotatingFileHandler's getFilesToDelete
Type: enhancement Stage: resolved
Components: Library (Lib) Versions: Python 3.7, Python 3.6, Python 3.5
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: Lovesh Harchandani, vinay.sajip
Priority: normal Keywords: patch

Created on 2017-07-22 07:17 by Lovesh Harchandani, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 2812 merged Lovesh Harchandani, 2017-07-22 07:56
PR 4466 merged python-dev, 2017-11-19 18:06
Messages (3)
msg298839 - (view) Author: Lovesh Harchandani (Lovesh Harchandani) * Date: 2017-07-22 07:17
At `/Lib/logging/` in `TimedRotatingFileHandler`'s `getFilesToDelete` method, filenames are sorted using `result.sort()` regardless of `len(result)`, if `len(result)` < backupCount, sorting is not required.
msg305104 - (view) Author: Vinay Sajip (vinay.sajip) * (Python committer) Date: 2017-10-27 07:04
New changeset afad147b59fe84b12317f7340ddd2deeecb22321 by Vinay Sajip (Lovesh Harchandani) in branch 'master':
bpo-30989: Sort in TimedRotatingFileHandler only when needed. (GH-2812)
msg306508 - (view) Author: Vinay Sajip (vinay.sajip) * (Python committer) Date: 2017-11-19 18:43
New changeset 65dffe58dd062385024eacbe75a0fa59ec12a993 by Vinay Sajip (Miss Islington (bot)) in branch '3.6':
bpo-30989: Sort in TimedRotatingFileHandler only when needed. (GH-2812) (GH-4466)
Date User Action Args
2022-04-11 14:58:49adminsetgithub: 75172
2017-11-19 22:28:03vinay.sajipsetstatus: open -> closed
resolution: fixed
stage: patch review -> resolved
2017-11-19 18:43:51vinay.sajipsetmessages: + msg306508
2017-11-19 18:06:57python-devsetkeywords: + patch
stage: patch review
pull_requests: + pull_request4399
2017-10-27 07:04:35vinay.sajipsetmessages: + msg305104
2017-10-26 22:17:00berker.peksagsetnosy: + vinay.sajip
2017-07-22 07:56:38Lovesh Harchandanisetpull_requests: + pull_request2863
2017-07-22 07:18:53Lovesh Harchandanisetcomponents: + Library (Lib)
2017-07-22 07:18:34Lovesh Harchandanisettype: enhancement
2017-07-22 07:17:22Lovesh Harchandanicreate