classification
Title: IDLE: Test config dialog font bold button and sample change
Type: enhancement Stage: resolved
Components: IDLE Versions: Python 3.7, Python 3.6
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: terry.reedy Nosy List: terry.reedy
Priority: normal Keywords:

Created on 2017-07-21 02:19 by terry.reedy, last changed 2017-07-22 19:33 by terry.reedy. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 2794 merged terry.reedy, 2017-07-21 05:59
PR 2796 merged terry.reedy, 2017-07-21 06:22
PR 2798 merged terry.reedy, 2017-07-21 07:26
PR 2805 closed cheryl.sabella, 2017-07-21 17:04
PR 2810 merged terry.reedy, 2017-07-22 04:14
Messages (10)
msg298761 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2017-07-21 02:33
I am working on this.
* Change 'test_highlight_sample' to 'highlight_sample.
* Change 'set_font_sample()' to 'set_samples()', since it also changes highlight_sample, and test.
* Add gui event test for 'bold' checkbutton.
* Perhaps add gui event test for size pulldown, or wait until replace.
* Test tab setting or wait until replace.

Do this before #24776 to redo page and #13802 to redo sample
msg298770 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2017-07-21 06:20
New changeset d0969d69245d9c4eea3498ba4bde4b4cd676ad7f by Terry Jan Reedy in branch 'master':
bpo-30981: IDLE -- Add more configdialog font page tests.  (#2794)
https://github.com/python/cpython/commit/d0969d69245d9c4eea3498ba4bde4b4cd676ad7f
msg298771 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2017-07-21 06:27
I left out gui event tests since they depends on the widgets, which will likely change.  I though about tests for the uncovered load_font_config and load_tab_config, but am not sure what to do that would not amount to copying their code.
msg298776 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2017-07-21 07:09
Viktor, I am aware that there are errors in the patch I pushed that will result in error on the Windows machines that run gui tests.  Am working on a fix now.
msg298779 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2017-07-21 07:28
I am too tired to fix this correctly right now, so I added @skip to class with failing tests.
msg298780 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2017-07-21 07:47
New changeset 7c5798ebfa9b822d6cedf1fc8c034f6ea90644dc by Terry Jan Reedy in branch 'master':
bpo-30981: temporarity skip failing IDLE test class (#2798)
https://github.com/python/cpython/commit/7c5798ebfa9b822d6cedf1fc8c034f6ea90644dc
msg298781 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2017-07-21 08:09
Thanks for the fix :-) (Don't forget to fix it later ;-))
msg298834 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2017-07-22 04:36
New changeset 616ecf18f3aacbd8d172e01673877b22fe946e54 by Terry Jan Reedy in branch 'master':
bpo-30981: IDLE: Augment one configdialog font page test (#2810)
https://github.com/python/cpython/commit/616ecf18f3aacbd8d172e01673877b22fe946e54
msg298837 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2017-07-22 04:56
New changeset 04864b491e3ce0f022e918ad344fb53a99ce2a1b by Terry Jan Reedy in branch '3.6':
[3.6] bpo-30981: IDLE -- Add more configdialog font page tests.  (GH-… (#2796)
https://github.com/python/cpython/commit/04864b491e3ce0f022e918ad344fb53a99ce2a1b
msg298867 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2017-07-22 19:33
Followup issue is #30993.
History
Date User Action Args
2017-07-22 19:33:43terry.reedysetnosy: - vstinner
messages: + msg298867
2017-07-22 04:58:45terry.reedysetstatus: open -> closed
title: IDLE: Add config dialog font page tests -> IDLE: Test config dialog font bold button and sample change
resolution: fixed
stage: needs patch -> resolved
2017-07-22 04:56:20terry.reedysetmessages: + msg298837
2017-07-22 04:36:15terry.reedysetmessages: + msg298834
2017-07-22 04:14:52terry.reedysetpull_requests: + pull_request2861
2017-07-21 17:04:09cheryl.sabellasetpull_requests: + pull_request2856
2017-07-21 08:09:18vstinnersetmessages: + msg298781
2017-07-21 07:47:03terry.reedysetmessages: + msg298780
2017-07-21 07:28:10terry.reedysetmessages: + msg298779
2017-07-21 07:26:19terry.reedysetpull_requests: + pull_request2848
2017-07-21 07:09:11terry.reedysetnosy: + vstinner
messages: + msg298776
2017-07-21 06:27:14terry.reedysetmessages: + msg298771
2017-07-21 06:22:23terry.reedysetpull_requests: + pull_request2846
2017-07-21 06:20:48terry.reedysetmessages: + msg298770
2017-07-21 05:59:22terry.reedysetpull_requests: + pull_request2844
2017-07-21 03:17:13terry.reedylinkissue30780 dependencies
2017-07-21 02:37:00terry.reedylinkissue24776 dependencies
2017-07-21 02:33:48terry.reedysetmessages: + msg298761
2017-07-21 02:19:00terry.reedycreate