classification
Title: test_unittest fails when hunting reference leaks
Type: Stage: resolved
Components: Versions: Python 3.7, Python 3.6, Python 3.5
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: serhiy.storchaka, vstinner
Priority: normal Keywords:

Created on 2017-06-30 09:50 by vstinner, last changed 2017-07-11 07:03 by serhiy.storchaka. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 2502 merged vstinner, 2017-06-30 10:38
PR 2505 merged vstinner, 2017-06-30 10:56
PR 2506 merged vstinner, 2017-06-30 10:57
Messages (6)
msg297370 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2017-06-30 09:50
Example of Python 3.5 (same error on master):

haypo@selma$ ./python -m test -R 3:3 -v test_unittest 
(...)
======================================================================
ERROR: test_discover_with_init_module_that_raises_SkipTest_on_import (unittest.test.test_discovery.TestDiscovery)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/haypo/prog/python/3.5/Lib/unittest/test/test_discovery.py", line 572, in test_discover_with_init_module_that_raises_SkipTest_on_import
    pickle.loads(pickle.dumps(suite, proto))
_pickle.PicklingError: Can't pickle <class 'unittest.loader.ModuleSkipped'>: attribute lookup ModuleSkipped on unittest.loader failed

======================================================================
ERROR: test_discover_with_module_that_raises_SkipTest_on_import (unittest.test.test_discovery.TestDiscovery)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/haypo/prog/python/3.5/Lib/unittest/test/test_discovery.py", line 548, in test_discover_with_module_that_raises_SkipTest_on_import
    pickle.loads(pickle.dumps(suite, proto))
_pickle.PicklingError: Can't pickle <class 'unittest.loader.ModuleSkipped'>: attribute lookup ModuleSkipped on unittest.loader failed
msg297371 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2017-06-30 10:39
Using --huntrleaks in regrtest runs this statement in regrtest:

   unittest.BaseTestSuite._cleanup = False

This line comes from bpo-11798.

https://github.com/python/cpython/pull/2502 fixes this issue.
msg297376 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2017-06-30 10:52
New changeset e4f9a2d2be42d5a2cdd624f8ed7cdf5028c5fbc3 by Victor Stinner in branch 'master':
bpo-30813: Fix unittest when hunting refleaks (#2502)
https://github.com/python/cpython/commit/e4f9a2d2be42d5a2cdd624f8ed7cdf5028c5fbc3
msg297386 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2017-06-30 11:12
New changeset 714afccf6e7644d21ce1a39e90bf83cb0c9a74f1 by Victor Stinner in branch '3.5':
bpo-30813: Fix unittest when hunting refleaks (#2502) (#2506)
https://github.com/python/cpython/commit/714afccf6e7644d21ce1a39e90bf83cb0c9a74f1
msg297390 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2017-06-30 11:12
New changeset 22d4e8fb99b16657eabfe7f9fee2d40a5ef882f6 by Victor Stinner in branch '3.6':
bpo-30813: Fix unittest when hunting refleaks (#2502) (#2505)
https://github.com/python/cpython/commit/22d4e8fb99b16657eabfe7f9fee2d40a5ef882f6
msg298134 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2017-07-11 07:03
Ah, this fixed issue25746!
History
Date User Action Args
2017-07-11 07:04:23serhiy.storchakalinkissue25746 superseder
2017-07-11 07:03:41serhiy.storchakasetnosy: + serhiy.storchaka
messages: + msg298134
2017-06-30 11:23:29vstinnersetstatus: open -> closed
resolution: fixed
stage: resolved
2017-06-30 11:12:24vstinnersetmessages: + msg297390
2017-06-30 11:12:18vstinnersetmessages: + msg297386
2017-06-30 10:57:33vstinnersetpull_requests: + pull_request2573
2017-06-30 10:56:27vstinnersetpull_requests: + pull_request2569
2017-06-30 10:52:55vstinnersetmessages: + msg297376
2017-06-30 10:39:40vstinnersetmessages: + msg297371
2017-06-30 10:38:05vstinnersetpull_requests: + pull_request2562
2017-06-30 09:50:28vstinnercreate