classification
Title: DOC: automatically create a venv and install Sphinx when running make
Type: Stage: patch review
Components: Documentation Versions: Python 3.7
process
Status: open Resolution:
Dependencies: Superseder:
Assigned To: docs@python Nosy List: cjrh, docs@python, willingc, zach.ware
Priority: normal Keywords: patch

Created on 2017-05-26 16:49 by cjrh, last changed 2017-11-09 10:50 by cjrh.

Pull Requests
URL Status Linked Edit
PR 1743 closed cjrh, 2017-05-26 16:49
PR 4346 open cjrh, 2017-11-09 10:47
Messages (4)
msg294556 - (view) Author: Caleb Hattingh (cjrh) * Date: 2017-05-26 16:49
Under guidance from zware during Pycon sprints, I've changed the Doc/ Makefile to automatically create a virtual environment and install Sphinx, all as part of the `make html` command.
msg305932 - (view) Author: Caleb Hattingh (cjrh) * Date: 2017-11-09 03:58
I messed up the PR through a failed rebase (trying to rebase my PR on top of upstream). I closed the PR as a result.  I have now fixed up my feature branch, but I have not resubmitted the PR.  Since the PR was left alone for many months, I'm ok with leaving things as is, and close this issue?
msg305936 - (view) Author: Zachary Ware (zach.ware) * (Python committer) Date: 2017-11-09 05:04
You should be able to force-push your branch (`git push -f origin auto-venv-docbuilder`, or replace `origin` with the correct remote name) to fix the existing PR.

Sorry I haven't gotten back to this previously; time to do a review and remembering that the PR exists have not coincided.
msg305955 - (view) Author: Caleb Hattingh (cjrh) * Date: 2017-11-09 10:50
No worries. I've made a new PR 4346. The old one was unsalvagable I'm afraid. Too many other people got added to the notifications list as a result of my incorrect rebase.  The new one is fine.
History
Date User Action Args
2017-11-09 10:50:19cjrhsetmessages: + msg305955
2017-11-09 10:47:33cjrhsetkeywords: + patch
pull_requests: + pull_request4303
2017-11-09 05:04:05zach.waresetmessages: + msg305936
2017-11-09 03:58:32cjrhsetmessages: + msg305932
2017-05-26 16:51:33Mariattasetstage: patch review
2017-05-26 16:49:48cjrhcreate