This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Title: Rename test.test_support to in 2.7
Type: enhancement Stage: resolved
Components: Tests Versions: Python 2.7
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: ezio.melotti, michael.foord, ncoghlan, serhiy.storchaka, zach.ware
Priority: normal Keywords:

Created on 2017-04-29 10:52 by serhiy.storchaka, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 1353 merged serhiy.storchaka, 2017-04-29 10:59
PR 1369 merged serhiy.storchaka, 2017-05-01 16:20
Messages (5)
msg292590 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2017-04-29 10:52
Proposed patch converts test.test_support into package and rename it to, move test.script_helper into the package.  Old names test.test_support and test.script_helper are left as aliases to and for compatibility (hence most tests don't need modification).

Benefits of this change:

1. This makes the structure of the test directory more compatible with 3.x. This helps bacporting tests. There were a number of cases when the only required change in backported 2.7 patch was changing "support" to "test_support". Many times backporting simple tests broke 2.7 buildbots because this change was not made.

2. This makes easier backporting changes in itself and backporting 3.x features from
msg292620 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2017-04-30 08:36
New changeset a694e092f6356970ca0d3e86000a3a829fb212b4 by Serhiy Storchaka in branch '2.7':
bpo-30207: Rename test.test_support to (#1353)
msg292664 - (view) Author: Zachary Ware (zach.ware) * (Python committer) Date: 2017-05-01 14:28
I like this change, but the install target in needs to be adjusted accordingly:
msg292670 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2017-05-01 16:21
Thank you for noticing this Zachary.
msg292675 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2017-05-01 16:53
New changeset 6bed8f95d72f622cb916bcebad651ccd3de6fe9d by Serhiy Storchaka in branch '2.7':
bpo-30207: Install the Lib/test/support directory. (#1369)
Date User Action Args
2022-04-11 14:58:45adminsetgithub: 74393
2017-05-01 17:28:34serhiy.storchakasetstatus: open -> closed
resolution: fixed
stage: patch review -> resolved
2017-05-01 16:53:47serhiy.storchakasetmessages: + msg292675
2017-05-01 16:21:48serhiy.storchakasetmessages: + msg292670
2017-05-01 16:20:56serhiy.storchakasetstatus: closed -> open
resolution: fixed -> (no value)
stage: resolved -> patch review
2017-05-01 16:20:22serhiy.storchakasetpull_requests: + pull_request1478
2017-05-01 14:28:27zach.waresetnosy: + zach.ware
messages: + msg292664
2017-04-30 08:38:10serhiy.storchakasetstatus: open -> closed
resolution: fixed
stage: patch review -> resolved
2017-04-30 08:37:00serhiy.storchakasetmessages: + msg292620
2017-04-29 10:59:26serhiy.storchakasetpull_requests: + pull_request1465
2017-04-29 10:52:06serhiy.storchakacreate