Title: --with-lto still implied by --enable-optimizations in Python 2.7
Type: compile error Stage: commit review
Components: Build Versions: Python 2.7
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: gregory.p.smith Nosy List: Arfrever, Hanno Schlichting, gregory.p.smith
Priority: normal Keywords:

Created on 2017-03-09 01:15 by Hanno Schlichting, last changed 2017-09-07 18:44 by gregory.p.smith. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 1858 merged python-dev, 2017-05-30 01:04
PR 2705 merged Hanno Schlichting, 2017-07-14 13:18
Messages (5)
msg289263 - (view) Author: Hanno Schlichting (Hanno Schlichting) * Date: 2017-03-09 01:15
I think the fix for issue28032 wasn't applied correctly to the 2.7 branch.

Compare the change in Python 2.7:

vs. for example Python 3.5:

In Python 3.5 the Py_LTO='true' line was before the Darwin block and got removed. In Python 2.7 the line was after the block and was left in place.

I'm guessing this was a simply mistake, while backporting the change.
msg294730 - (view) Author: Gregory P. Smith (gregory.p.smith) * (Python committer) Date: 2017-05-30 02:07
New changeset 1f29cefc87c4c2ee629367ebe97a287d8e0b3e29 by Gregory P. Smith (Hanno Schlichting) in branch '2.7':
bpo-29766: Do not force --with-lto to true for --enable-optimizations (#1858)
msg294731 - (view) Author: Gregory P. Smith (gregory.p.smith) * (Python committer) Date: 2017-05-30 02:08
indeed, my mistake in the original backport.  thanks!
msg297996 - (view) Author: Arfrever Frehtes Taifersar Arahesis (Arfrever) * Date: 2017-07-09 20:57
>     bpo-29766: Do not force --with-lto to true for --enable-optimizations (#1858)
>     This fixes a faulty backport to the Python 2.7 branch only of Details in the bpo-29766.

This commit is still faulty :) .
It changes configure without, so this change is lost for these users who locally adjust for some reason and regenerate configure with autoconf.
msg301608 - (view) Author: Gregory P. Smith (gregory.p.smith) * (Python committer) Date: 2017-09-07 18:43
New changeset abea972d2881a1a04ec265f993bb9b56bbc7b224 by Gregory P. Smith (Hanno Schlichting) in branch '2.7':
[2.7] bpo-29766: Fix configure/.ac to match LTO/enable-optimizations behavior. (#2705)
Date User Action Args
2017-09-07 18:44:20gregory.p.smithsetstatus: open -> closed
resolution: fixed
stage: resolved -> commit review
2017-09-07 18:43:49gregory.p.smithsetmessages: + msg301608
2017-07-14 13:18:16Hanno Schlichtingsetpull_requests: + pull_request2770
2017-07-09 20:57:04Arfreversetstatus: closed -> open

nosy: + Arfrever
messages: + msg297996

resolution: fixed -> (no value)
2017-05-30 02:08:09gregory.p.smithsetstatus: open -> closed
type: compile error
messages: + msg294731

assignee: gregory.p.smith
resolution: fixed
stage: resolved
2017-05-30 02:07:09gregory.p.smithsetmessages: + msg294730
2017-05-30 01:04:03python-devsetpull_requests: + pull_request1941
2017-03-09 01:15:04Hanno Schlichtingcreate