classification
Title: --enable-optimizations compiler flag has no effect
Type: behavior Stage: resolved
Components: Build Versions: Python 3.7, Python 3.6, Python 3.5, Python 2.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: awang, inada.naoki, vstinner
Priority: normal Keywords:

Created on 2017-02-24 23:20 by awang, last changed 2017-03-28 16:51 by inada.naoki. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 129 merged awang, 2017-02-24 23:20
PR 869 merged inada.naoki, 2017-03-28 12:57
PR 870 closed vstinner, 2017-03-28 13:00
PR 871 merged inada.naoki, 2017-03-28 13:07
PR 873 merged inada.naoki, 2017-03-28 13:15
Messages (7)
msg288535 - (view) Author: Alex Wang (awang) * Date: 2017-02-24 23:20
PR submitted here: https://github.com/python/cpython/pull/129
msg288536 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2017-02-24 23:35
The flag has an effect, I tested it today ;-)

Can you please elaborate why you consider that the flag has no effect?
msg288537 - (view) Author: Alex Wang (awang) * Date: 2017-02-24 23:39
At least when I last built Python, configure always said that optimizations were not enabled regardless of whether I passed in the flag.

From what it looked like to me, it's because configure uses the $enableval variable to store the result of the check for --enable-optimizations, but the script checks $withval
msg290705 - (view) Author: Inada Naoki (inada.naoki) * (Python committer) Date: 2017-03-28 12:50
New changeset 8cea5929f52801b0ce5928b46ef836e99a24321a by INADA Naoki (Alex Wang) in branch 'master':
bpo-29643: Fix check for --enable-optimizations (GH-129)
https://github.com/python/cpython/commit/8cea5929f52801b0ce5928b46ef836e99a24321a
msg290730 - (view) Author: Inada Naoki (inada.naoki) * (Python committer) Date: 2017-03-28 15:25
New changeset f01de61a8efea8319c65365898982f929d59a895 by INADA Naoki in branch '3.6':
bpo-29643: Fix check for --enable-optimizations (GH-869)
https://github.com/python/cpython/commit/f01de61a8efea8319c65365898982f929d59a895
msg290731 - (view) Author: Inada Naoki (inada.naoki) * (Python committer) Date: 2017-03-28 15:26
New changeset e6a49531568561fe5aaf662259ecb7b4bc2426be by INADA Naoki in branch '3.5':
bpo-29643: Fix check for --enable-optimizations (GH-871)
https://github.com/python/cpython/commit/e6a49531568561fe5aaf662259ecb7b4bc2426be
msg290741 - (view) Author: Inada Naoki (inada.naoki) * (Python committer) Date: 2017-03-28 16:50
New changeset 6a04ef7ceddae0930eba6cc57ba2ebfcef00abab by INADA Naoki in branch '2.7':
bpo-29643: Fix check for --enable-optimizations (GH-873)
https://github.com/python/cpython/commit/6a04ef7ceddae0930eba6cc57ba2ebfcef00abab
History
Date User Action Args
2017-03-28 16:51:50inada.naokisetstatus: open -> closed
resolution: fixed
stage: resolved
2017-03-28 16:50:50inada.naokisetmessages: + msg290741
2017-03-28 15:26:31inada.naokisetmessages: + msg290731
2017-03-28 15:25:29inada.naokisetmessages: + msg290730
2017-03-28 13:15:38inada.naokisetpull_requests: + pull_request771
2017-03-28 13:07:26inada.naokisetpull_requests: + pull_request770
2017-03-28 13:00:49vstinnersetpull_requests: + pull_request769
2017-03-28 12:57:29inada.naokisetpull_requests: + pull_request768
2017-03-28 12:50:53inada.naokisetnosy: + inada.naoki
messages: + msg290705
2017-02-24 23:39:02awangsetmessages: + msg288537
2017-02-24 23:35:04vstinnersetnosy: + vstinner
messages: + msg288536
2017-02-24 23:20:21awangsetpull_requests: + pull_request253
2017-02-24 23:20:10awangcreate