classification
Title: Clean up some checks in dict implementation
Type: enhancement Stage: resolved
Components: Interpreter Core Versions: Python 3.7, Python 3.6
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: serhiy.storchaka Nosy List: methane, python-dev, serhiy.storchaka, vstinner, xiang.zhang
Priority: normal Keywords: patch

Created on 2016-09-18 09:12 by xiang.zhang, last changed 2016-09-26 18:31 by serhiy.storchaka. This issue is now closed.

Files
File name Uploaded Description Edit
dict_clean_up.patch xiang.zhang, 2016-09-18 09:12 review
dict_clean_up_v2.patch xiang.zhang, 2016-09-18 14:56 review
Messages (4)
msg276875 - (view) Author: Xiang Zhang (xiang.zhang) * (Python committer) Date: 2016-09-18 09:12
The proposed patch cleans up some unnecessary parts in dict implementation especially NULL checks in lookup functions. There are four states a DictKeyEntry can be. Only in unused(empty) and dummy states me_key can be NULL. So NULL checks in used and pending states are not needed.
msg276892 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2016-09-18 14:30
LGTM if address methane's comment.
msg276894 - (view) Author: Xiang Zhang (xiang.zhang) * (Python committer) Date: 2016-09-18 14:56
Apply methane's comment, preserving the comment.
msg277444 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2016-09-26 18:30
New changeset 1d41d741bb5b by Serhiy Storchaka in branch '3.6':
Issue #28194: Clean up some checks in dict implementation.
https://hg.python.org/cpython/rev/1d41d741bb5b

New changeset b83a70afca39 by Serhiy Storchaka in branch 'default':
Issue #28194: Clean up some checks in dict implementation.
https://hg.python.org/cpython/rev/b83a70afca39
History
Date User Action Args
2016-09-26 18:31:36serhiy.storchakasetstatus: open -> closed
resolution: fixed
stage: patch review -> resolved
2016-09-26 18:30:23python-devsetnosy: + python-dev
messages: + msg277444
2016-09-26 08:57:39serhiy.storchakasetassignee: serhiy.storchaka
2016-09-18 14:56:41xiang.zhangsetfiles: + dict_clean_up_v2.patch

messages: + msg276894
2016-09-18 14:30:49serhiy.storchakasetmessages: + msg276892
2016-09-18 09:12:17xiang.zhangcreate