➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2016-09-12 01:33 by yselivanov, last changed 2022-04-11 14:58 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| issue28088.patch | Mariatta, 2016-10-02 00:46 | review | ||
| issue28088v2.patch | Mariatta, 2016-10-28 04:02 | review | ||
| Messages (9) | |||
|---|---|---|---|
| msg277836 - (view) | Author: Mariatta (Mariatta) *  |
Date: 2016-10-02 00:46 | |
Added the documentation for set_protocol and get_protocol. |
|||
| msg277954 - (view) | Author: Inada Naoki (methane) * |
Date: 2016-10-03 11:44 | |
lgtm. But I think adding note like following may be helpful to avoid users try switching protocols which protocol author doesn't expect. (I'm not good English writer. I hope someone polish my sentence). .. note:: Generally speaking, switching protocols requires special knowledge about two protocols. For example, old protocol may have inner receive buffer and new protocol should take over it. Transport doesn't take care about such issues. Protocols should support switching protocol using this API. |
|||
| msg279575 - (view) | Author: Mariatta (Mariatta) * |
Date: 2016-10-28 04:02 | |
I added a note like this. .. note:: Switching protocol should only be done when both protocols are documented to support the switch. Would this work? Would appreciate any feedback of how to properly document this behavior. Thanks. |
|||
| msg279576 - (view) | Author: Inada Naoki (methane) * |
Date: 2016-10-28 04:06 | |
LGTM |
|||
| msg279951 - (view) | Author: Guido van Rossum (gvanrossum) * |
Date: 2016-11-02 21:22 | |
LGTM too. Can someone add this to the asyncio docs (starting at the 3.5 branch please)? |
|||
| msg280038 - (view) | Author: Roundup Robot (python-dev)  |
Date: 2016-11-04 07:35 | |
New changeset 3f5af4a25995 by INADA Naoki in branch '3.5': Issue #28088: Document Transport.set_protocol and get_protocol https://hg.python.org/cpython/rev/3f5af4a25995 New changeset a5e52b7be71f by INADA Naoki in branch '3.6': Issue #28088: Document Transport.set_protocol and get_protocol. https://hg.python.org/cpython/rev/a5e52b7be71f New changeset a0299574a733 by INADA Naoki in branch 'default': Issue #28088: Document Transport.set_protocol and get_protocol. https://hg.python.org/cpython/rev/a0299574a733 |
|||
| msg280231 - (view) | Author: Roundup Robot (python-dev) |
Date: 2016-11-07 20:21 | |
New changeset f4e86b1b051e by Berker Peksag in branch '3.5': Issue #28088: Don't include self in method signature https://hg.python.org/cpython/rev/f4e86b1b051e New changeset f2858945c058 by Berker Peksag in branch '3.6': Issue #28088: Merge from 3.5 https://hg.python.org/cpython/rev/f2858945c058 New changeset 62b7614970bd by Berker Peksag in branch 'default': Issue #28088: Merge from 3.6 https://hg.python.org/cpython/rev/62b7614970bd |
|||
| msg280232 - (view) | Author: Berker Peksag (berker.peksag) * |
Date: 2016-11-07 20:25 | |
I just removed self from method signatures (we don't usually include it) and updated the versionadded directives to 3.5.3 since it was also backported to 3.5 in f12a59311885. Please let me know if got the 3.5 version wrong, thanks! |
|||
| msg280246 - (view) | Author: Guido van Rossum (gvanrossum) * |
Date: 2016-11-07 21:22 | |
Good point. Thanks Berker! |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:58:36 | admin | set | github: 72275 |
| 2016-11-07 21:22:10 | gvanrossum | set | messages: + msg280246 |
| 2016-11-07 20:25:49 | berker.peksag | set | priority: release blocker -> normal nosy: - larry |
| 2016-11-07 20:25:21 | berker.peksag | set | nosy:
+ larry, berker.peksag messages: + msg280232 versions: + Python 3.5, Python 3.7 |
| 2016-11-07 20:21:42 | python-dev | set | messages: + msg280231 |
| 2016-11-04 07:36:18 | methane | set | status: open -> closed resolution: fixed stage: needs patch -> resolved |
| 2016-11-04 07:35:42 | python-dev | set | nosy:
+ python-dev messages: + msg280038 |
| 2016-11-02 21:22:34 | gvanrossum | set | messages: + msg279951 |
| 2016-10-28 04:06:45 | methane | set | messages: + msg279576 |
| 2016-10-28 04:02:02 | Mariatta | set | files:
+ issue28088v2.patch messages: + msg279575 |
| 2016-10-03 11:44:50 | methane | set | nosy:
+ methane messages: + msg277954 |
| 2016-10-02 00:46:13 | Mariatta | set | files:
+ issue28088.patch keywords: + patch messages: + msg277836 |
| 2016-10-01 21:39:05 | Mariatta | set | nosy:
+ Mariatta |
| 2016-09-12 01:34:12 | yselivanov | set | nosy:
+ docs@python assignee: docs@python components: + Documentation type: enhancement stage: needs patch |
| 2016-09-12 01:33:02 | yselivanov | create | |