classification
Title: Incorrect comment in PyModule_ExcDef
Type: enhancement Stage: resolved
Components: Versions: Python 3.7, Python 3.6
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: ncoghlan, python-dev, serhiy.storchaka, xiang.zhang
Priority: normal Keywords: patch

Created on 2016-08-31 14:38 by xiang.zhang, last changed 2016-09-26 20:16 by serhiy.storchaka. This issue is now closed.

Files
File name Uploaded Description Edit
PyModule_ExcDef_comment.patch xiang.zhang, 2016-08-31 14:38 review
Messages (3)
msg274024 - (view) Author: Xiang Zhang (xiang.zhang) * (Python committer) Date: 2016-08-31 14:38
There is a comment in PyModule_ExcDef:

    /* handled in PyModule_CreateFromSlots */

But there seems never exists PyModule_CreateFromSlots, I think PyModule_CreateFromSlots should be PyModule_FromDefAndSpec2.
msg277457 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2016-09-26 20:15
New changeset 2cf16c627c17 by Serhiy Storchaka in branch '3.6':
Issue #27914: Fixed a comment in PyModule_ExcDef.
https://hg.python.org/cpython/rev/2cf16c627c17

New changeset a944b08d1ac7 by Serhiy Storchaka in branch 'default':
Issue #27914: Fixed a comment in PyModule_ExcDef.
https://hg.python.org/cpython/rev/a944b08d1ac7
msg277459 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2016-09-26 20:16
Good catch!
History
Date User Action Args
2016-09-26 20:16:40serhiy.storchakasetstatus: open -> closed

versions: + Python 3.7, - Python 3.5
nosy: + serhiy.storchaka

messages: + msg277459
resolution: fixed
stage: resolved
2016-09-26 20:15:26python-devsetnosy: + python-dev
messages: + msg277457
2016-08-31 14:38:40xiang.zhangcreate