classification
Title: Clean up some Py_XDECREFs in rangeobject.c and bltinmodule.c
Type: enhancement Stage: resolved
Components: Interpreter Core Versions: Python 3.6
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: mark.dickinson, python-dev, rhettinger, serhiy.storchaka, xiang.zhang
Priority: normal Keywords: patch

Created on 2016-06-17 07:39 by xiang.zhang, last changed 2016-06-18 06:45 by serhiy.storchaka. This issue is now closed.

Files
File name Uploaded Description Edit
cleanup_some_xdecrefs.patch xiang.zhang, 2016-06-17 07:39 review
cleanup_some_xdecrefs_v2.patch xiang.zhang, 2016-06-17 15:26 review
Messages (5)
msg268711 - (view) Author: Xiang Zhang (xiang.zhang) * (Python committer) Date: 2016-06-17 07:39
Some Py_XDECREFs in rangeobject.c and bltinmodule.c are not necessary. Py_DECREF is enough. Clean up them.
msg268724 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2016-06-17 13:19
Mostly good except longrangeiter_dealloc().
msg268729 - (view) Author: Xiang Zhang (xiang.zhang) * (Python committer) Date: 2016-06-17 15:26
Thanks for review. Eliminate the wrongs ones.
msg268744 - (view) Author: Raymond Hettinger (rhettinger) * (Python committer) Date: 2016-06-17 22:40
v2 looks correct.
msg268768 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2016-06-18 06:44
New changeset 52931189d7ee by Serhiy Storchaka in branch 'default':
Issue #27342: Replaced some Py_XDECREFs with Py_DECREFs.
https://hg.python.org/cpython/rev/52931189d7ee
History
Date User Action Args
2016-06-18 06:45:18serhiy.storchakasetstatus: open -> closed
resolution: fixed
stage: patch review -> resolved
2016-06-18 06:44:28python-devsetnosy: + python-dev
messages: + msg268768
2016-06-17 22:40:07rhettingersetnosy: + rhettinger
messages: + msg268744
2016-06-17 15:26:00xiang.zhangsetfiles: + cleanup_some_xdecrefs_v2.patch

messages: + msg268729
2016-06-17 13:19:14serhiy.storchakasettype: enhancement
components: + Interpreter Core
versions: + Python 3.6
nosy: + mark.dickinson

messages: + msg268724
stage: patch review
2016-06-17 08:36:31serhiy.storchakasetnosy: + serhiy.storchaka
2016-06-17 07:39:28xiang.zhangcreate