Created on 2016-05-12 06:48 by serhiy.storchaka, last changed 2016-05-12 07:53 by serhiy.storchaka. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| float_fromhex.patch | serhiy.storchaka, 2016-05-12 06:48 | review | ||
| Messages (6) | |||
|---|---|---|---|
| msg265366 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) *  |
Date: 2016-05-12 06:48 | |
Proposed patch makes float.fromhex() faster for exact float. $ ./python -m timeit -s "h = float.hex(1.23)" -- "float.fromhex(h)" Unpatched: 1000000 loops, best of 3: 0.886 usec per loop Patched: 1000000 loops, best of 3: 0.519 usec per loop |
|||
| msg265367 - (view) | Author: Mark Dickinson (mark.dickinson) * |
Date: 2016-05-12 07:00 | |
LGTM |
|||
| msg265369 - (view) | Author: Roundup Robot (python-dev)  |
Date: 2016-05-12 07:21 | |
New changeset 3b19660611a4 by Serhiy Storchaka in branch 'default': Issue #27005: Optimized the float.fromhex() class method for exact float. https://hg.python.org/cpython/rev/3b19660611a4 |
|||
| msg265370 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * |
Date: 2016-05-12 07:22 | |
Thank you Mark. |
|||
| msg265371 - (view) | Author: Roundup Robot (python-dev) |
Date: 2016-05-12 07:32 | |
New changeset 1bae2a6bb37c by Serhiy Storchaka in branch 'default': Issue #27005: Fixed the call of PyObject_CallFunctionObjArgs(). https://hg.python.org/cpython/rev/1bae2a6bb37c |
|||
| msg265374 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * |
Date: 2016-05-12 07:53 | |
A mistake in using PyObject_CallFunctionObjArgs() caused a crash in using fromhex() for subclasses. New tests added in issue23640 covers this case. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2016-05-12 07:53:10 | serhiy.storchaka | set | messages: + msg265374 |
| 2016-05-12 07:32:54 | python-dev | set | messages: + msg265371 |
| 2016-05-12 07:22:17 | serhiy.storchaka | set | status: open -> closed messages: + msg265370 assignee: serhiy.storchaka resolution: fixed stage: patch review -> resolved |
| 2016-05-12 07:21:41 | python-dev | set | nosy:
+ python-dev messages: + msg265369 |
| 2016-05-12 07:00:54 | mark.dickinson | set | messages: + msg265367 |
| 2016-05-12 06:48:22 | serhiy.storchaka | create | |