➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2016-04-22 16:59 by franciscouzo, last changed 2022-04-11 14:58 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| scripts_google.patch | franciscouzo, 2016-04-22 16:59 | review | ||
| scripts_google_v2.patch | franciscouzo, 2016-04-29 22:13 | review | ||
| scripts_google_v3.patch | franciscouzo, 2016-09-14 07:28 | review | ||
| Messages (7) | |||
|---|---|---|---|
| msg264028 - (view) | Author: Berker Peksag (berker.peksag) *  |
Date: 2016-04-22 17:37 | |
I don't think google.py is useful anymore. I'd prefer to just remove it from the cpython repository. |
|||
| msg264030 - (view) | Author: Ned Deily (ned.deily) * |
Date: 2016-04-22 21:56 | |
FWIW, I'm -0 on removing google.py and +0.5 on the refactoring. It seems like it could still be useful as either an example or a tool. Georg did a cleanup of the Tools directory several years ago (in Issue7962). Rather than removing one script, it might be more useful to review them all for relevance. In any case, thanks for the contribution, Francisco. |
|||
| msg264064 - (view) | Author: Francisco Couzo (franciscouzo) * | Date: 2016-04-23 17:27 | |
I was also going to refactor the other demo scripts, but first I wanted to make sure there was at least some kind of interest in it. |
|||
| msg264513 - (view) | Author: Terry J. Reedy (terry.reedy) * |
Date: 2016-04-29 18:10 | |
Demos should demonstrate proper modern code. 1. Contain decent docstrings. 2. Dependency on sys.argv, derived from a command line, should be in the 'if __name__' clause triggered when the module *is* invoked from command line. Especially in simple cases like this, it should be possible to import the module and call main(args) without involving sys.argv. See review. |
|||
| msg264527 - (view) | Author: Francisco Couzo (franciscouzo) * | Date: 2016-04-29 22:13 | |
Here's the patch with the modifications from the review. |
|||
| msg276392 - (view) | Author: Roundup Robot (python-dev)  |
Date: 2016-09-14 07:58 | |
New changeset f8c11b61cfb7 by Berker Peksag in branch 'default': Issue #26830: Refactor Tools/scripts/google.py https://hg.python.org/cpython/rev/f8c11b61cfb7 |
|||
| msg276393 - (view) | Author: Berker Peksag (berker.peksag) * |
Date: 2016-09-14 07:59 | |
Thanks! |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:58:30 | admin | set | github: 71017 |
| 2016-09-14 07:59:16 | berker.peksag | set | status: open -> closed versions: + Python 3.7, - Python 3.6 messages: + msg276393 resolution: fixed stage: patch review -> resolved |
| 2016-09-14 07:58:40 | python-dev | set | nosy:
+ python-dev messages: + msg276392 |
| 2016-09-14 07:28:47 | franciscouzo | set | files: + scripts_google_v3.patch |
| 2016-04-29 22:13:24 | franciscouzo | set | files:
+ scripts_google_v2.patch messages: + msg264527 |
| 2016-04-29 18:10:47 | terry.reedy | set | nosy:
+ terry.reedy messages: + msg264513 |
| 2016-04-23 17:27:32 | franciscouzo | set | messages: + msg264064 |
| 2016-04-22 21:56:34 | ned.deily | set | nosy:
+ ned.deily messages: + msg264030 |
| 2016-04-22 17:37:34 | berker.peksag | set | nosy:
+ berker.peksag messages: + msg264028 components: + Demos and Tools stage: patch review |
| 2016-04-22 16:59:17 | franciscouzo | create | |