classification
Title: test_os.WalkTests.test_walk_topdown don't test fwalk and Bytes
Type: behavior Stage: resolved
Components: Tests Versions: Python 3.6, Python 3.5
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: serhiy.storchaka Nosy List: loewis, palaviv, python-dev, serhiy.storchaka
Priority: normal Keywords: patch

Created on 2016-04-16 14:24 by palaviv, last changed 2016-04-16 14:52 by serhiy.storchaka. This issue is now closed.

Files
File name Uploaded Description Edit
os-test-walk-topdown-use-self-walk.patch palaviv, 2016-04-16 14:24 review
Messages (3)
msg263558 - (view) Author: Aviv Palivoda (palaviv) * Date: 2016-04-16 14:24
test_walk_topdown call os.walk directly instead of using self.walk. This test currently run 3 time's while checking the same thing. The test should use self.walk to check fwalk and Bytes as well.
msg263563 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2016-04-16 14:49
The patch LGTM. Thank you Aviv.
msg263564 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2016-04-16 14:51
New changeset e44a2dc62c11 by Serhiy Storchaka in branch '3.5':
Issue #26783: test_os.WalkTests.test_walk_topdown did't test fwalk and bytes.
https://hg.python.org/cpython/rev/e44a2dc62c11

New changeset be96434b8777 by Serhiy Storchaka in branch 'default':
Issue #26783: test_os.WalkTests.test_walk_topdown did't test fwalk and bytes.
https://hg.python.org/cpython/rev/be96434b8777
History
Date User Action Args
2016-04-16 14:52:39serhiy.storchakasetstatus: open -> closed
resolution: fixed
stage: commit review -> resolved
2016-04-16 14:51:45python-devsetnosy: + python-dev
messages: + msg263564
2016-04-16 14:49:41serhiy.storchakasetassignee: serhiy.storchaka
type: behavior
versions: + Python 3.5
nosy: + serhiy.storchaka

messages: + msg263563
stage: commit review
2016-04-16 14:24:27palavivcreate