classification
Title: Improve test coverage on urllib.parse
Type: enhancement Stage: resolved
Components: Tests Versions: Python 3.6, Python 3.5, Python 2.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: luiz.poleto, orsenthil, python-dev
Priority: normal Keywords: patch

Created on 2016-04-16 06:54 by luiz.poleto, last changed 2016-04-16 14:36 by orsenthil. This issue is now closed.

Files
File name Uploaded Description Edit
urllib.parse_test_coverage.patch luiz.poleto, 2016-04-16 06:54 review
Messages (3)
msg263538 - (view) Author: Luiz Poleto (luiz.poleto) * Date: 2016-04-16 06:54
urllib.parse has two methods, parse_qs and parse_qsl to parse a query string and return its parameters/values as a dictionary or a list, respectively. However, the unit tests only tests parse_qsl, which is also incomplete since both parse_qs and parse_qsl support & and ; as separators for key=value pairs and there are only test scenarios using &.

The attached patch add a new test for parse_qs as well as new scenarios including ; as separator.
msg263559 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2016-04-16 14:34
New changeset 8f02747ff908 by Senthil Kumaran in branch '3.5':
issue26775 - Improve test coverage for urllib.parse
https://hg.python.org/cpython/rev/8f02747ff908

New changeset 401dca6ac084 by Senthil Kumaran in branch 'default':
merge 3.5
https://hg.python.org/cpython/rev/401dca6ac084
msg263561 - (view) Author: Senthil Kumaran (orsenthil) * (Python committer) Date: 2016-04-16 14:36
Thanks for your contribution, Luiz. It's a useful improvement.
Committed to all active branches.

2.7 changeset: 101012:e3ed950ad728
History
Date User Action Args
2016-04-16 14:36:15orsenthilsetstatus: open -> closed

versions: + Python 2.7, Python 3.5
nosy: + orsenthil

messages: + msg263561
resolution: fixed
stage: resolved
2016-04-16 14:34:32python-devsetnosy: + python-dev
messages: + msg263559
2016-04-16 06:54:29luiz.poletocreate