classification
Title: Duplicated keyword in distutils metadata
Type: enhancement Stage: resolved
Components: Distutils Versions: Python 3.6
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: Augustin Laville, berker.peksag, dstufft, eric.araujo, ezio.melotti, python-dev
Priority: normal Keywords: patch

Created on 2016-01-12 09:44 by Augustin Laville, last changed 2016-04-23 22:59 by berker.peksag. This issue is now closed.

Files
File name Uploaded Description Edit
issue26089.diff ezio.melotti, 2016-01-12 09:55 review
Messages (4)
msg258091 - (view) Author: Augustin Laville (Augustin Laville) Date: 2016-01-12 09:44
The line https://hg.python.org/cpython/file/tip/Lib/distutils/dist.py#l1016 contains the word "licence" twice.

Check only on Python, 3.5 and 3.6, may be in others versions.
msg258093 - (view) Author: Ezio Melotti (ezio.melotti) * (Python committer) Date: 2016-01-12 09:55
This seems to be because the alternative spelling "licence" was also included in the list, and got changed in #693470/178d19cff163.
Because of that change, the method get_licence() is not supported anymore, but at this point removing the duplicate "license" should be safe.
Attached a patch.
(Note that there seem to be no tests for the "licence" alias in Lib/distutils/tests)
msg264075 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2016-04-23 22:54
New changeset 21e522177ca0 by Berker Peksag in branch 'default':
Issue #26089: Remove duplicate field 'license' from DistributionMetadata
https://hg.python.org/cpython/rev/21e522177ca0
msg264076 - (view) Author: Berker Peksag (berker.peksag) * (Python committer) Date: 2016-04-23 22:59
I just committed Ezio's patch. Thanks!
History
Date User Action Args
2016-04-23 22:59:29berker.peksagsetstatus: open -> closed

nosy: + berker.peksag
messages: + msg264076

resolution: fixed
stage: commit review -> resolved
2016-04-23 22:54:55python-devsetnosy: + python-dev
messages: + msg264075
2016-01-12 09:55:38ezio.melottisetfiles: + issue26089.diff

type: resource usage -> enhancement
versions: - Python 3.5
keywords: + patch
nosy: + ezio.melotti

messages: + msg258093
stage: commit review
2016-01-12 09:44:50Augustin Lavillecreate