classification
Title: Don't use distutils in test_shutil
Type: enhancement Stage: resolved
Components: Tests Versions: Python 3.6, Python 3.4, Python 3.5, Python 2.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: eric.araujo, matrixise, python-dev, serhiy.storchaka, tarek
Priority: normal Keywords: patch

Created on 2015-11-20 22:13 by serhiy.storchaka, last changed 2015-11-21 12:25 by matrixise. This issue is now closed.

Files
File name Uploaded Description Edit
test_shutil_no_distutils.patch serhiy.storchaka, 2015-11-20 22:13 review
Messages (5)
msg255023 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2015-11-20 22:13
The distutils package is used in test_shutil to search and run external archivers. But using distutils can have side effects (see issue25607).

Proposed patch replaces distutils with standard functions for searching executables and running command, shutil.which() and subprocess.check_call().
msg255025 - (view) Author: Stéphane Wirtel (matrixise) * (Python committer) Date: 2015-11-20 22:19
Works fine on my laptop with 3.6. and the code is right
msg255052 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2015-11-21 12:12
New changeset c50cbb5d5ece by Serhiy Storchaka in branch '3.4':
Issue #25686: test_shutil no longer uses the distutils package for searching
https://hg.python.org/cpython/rev/c50cbb5d5ece

New changeset df11d58fce00 by Serhiy Storchaka in branch '3.5':
Issue #25686: test_shutil no longer uses the distutils package for searching
https://hg.python.org/cpython/rev/df11d58fce00

New changeset 3ccd9dfb8ab7 by Serhiy Storchaka in branch 'default':
Issue #25686: test_shutil no longer uses the distutils package for searching
https://hg.python.org/cpython/rev/3ccd9dfb8ab7

New changeset 81b4b130a891 by Serhiy Storchaka in branch '2.7':
Issue #25686: test_shutil no longer uses the distutils package for running
https://hg.python.org/cpython/rev/81b4b130a891
msg255053 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2015-11-21 12:13
Thank you Stéphane for your review.
msg255055 - (view) Author: Stéphane Wirtel (matrixise) * (Python committer) Date: 2015-11-21 12:25
Welcome Serhiy,
History
Date User Action Args
2015-11-21 12:25:52matrixisesetmessages: + msg255055
2015-11-21 12:13:31serhiy.storchakasetstatus: open -> closed
versions: + Python 2.7
messages: + msg255053

resolution: fixed
stage: patch review -> resolved
2015-11-21 12:12:23python-devsetnosy: + python-dev
messages: + msg255052
2015-11-20 22:19:32matrixisesetnosy: + matrixise
messages: + msg255025
2015-11-20 22:13:35serhiy.storchakacreate