classification
Title: asyncio: support 'async with' for locks
Type: enhancement Stage: resolved
Components: asyncio Versions: Python 3.5
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: yselivanov Nosy List: asvetlov, gvanrossum, python-dev, vstinner, yselivanov
Priority: normal Keywords: patch

Created on 2015-05-13 16:30 by yselivanov, last changed 2015-05-13 18:40 by yselivanov. This issue is now closed.

Files
File name Uploaded Description Edit
alock.patch yselivanov, 2015-05-13 16:30 review
alock_2.patch yselivanov, 2015-05-13 17:51 review
Messages (4)
msg243102 - (view) Author: Yury Selivanov (yselivanov) * (Python committer) Date: 2015-05-13 16:30
The attached patch makes Locks, Conditions, Semaphores, and BoundedSemaphores support new 'async with' syntax.

Because the patch contains a file that will only be checked in to the CPython repo (test_pep492.py), I decided to create the issue on bugs.python.org instead of asyncio GH repo.

Please review.
msg243107 - (view) Author: Yury Selivanov (yselivanov) * (Python committer) Date: 2015-05-13 17:51
Updated patch is attached:

- '__aenter__' returns None
- "with await lock" is now supported.
msg243110 - (view) Author: Roundup Robot (python-dev) Date: 2015-05-13 18:10
New changeset 616f15f05530 by Yury Selivanov in branch 'default':
Issue 24178: support 'async with' for asyncio locks.
https://hg.python.org/cpython/rev/616f15f05530
msg243115 - (view) Author: Yury Selivanov (yselivanov) * (Python committer) Date: 2015-05-13 18:40
Guido, thanks for review. Closing the issue.
History
Date User Action Args
2015-05-13 18:40:08yselivanovsetstatus: open -> closed
resolution: fixed
messages: + msg243115

stage: patch review -> resolved
2015-05-13 18:10:45python-devsetnosy: + python-dev
messages: + msg243110
2015-05-13 17:51:11yselivanovsetfiles: + alock_2.patch

messages: + msg243107
2015-05-13 16:30:54yselivanovcreate