classification
Title: Add git support to make patchcheck
Type: enhancement Stage: resolved
Components: Build Versions: Python 3.5, Python 3.4
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: berker.peksag, christian.heimes, python-dev
Priority: normal Keywords: patch

Created on 2015-04-22 20:29 by christian.heimes, last changed 2015-04-23 09:26 by christian.heimes. This issue is now closed.

Files
File name Uploaded Description Edit
patchcheck_git.patch christian.heimes, 2015-04-22 20:29 review
Messages (4)
msg241824 - (view) Author: Christian Heimes (christian.heimes) * (Python committer) Date: 2015-04-22 20:29
'make patchcheck' supports only Mercurial checkouts. The tool uses the 'hg status' command to find modified files. My patch implements 'git status' support in order to make the patch check tool available on git checkouts.
msg241840 - (view) Author: Berker Peksag (berker.peksag) * (Python committer) Date: 2015-04-23 03:59
LGTM
msg241856 - (view) Author: Roundup Robot (python-dev) Date: 2015-04-23 09:26
New changeset 0f9c43fb189d by Christian Heimes in branch '3.4':
Issue #24031: make patchcheck now supports git checkouts, too.
https://hg.python.org/cpython/rev/0f9c43fb189d

New changeset d1b706e57fbe by Christian Heimes in branch 'default':
Issue #24031: make patchcheck now supports git checkouts, too.
https://hg.python.org/cpython/rev/d1b706e57fbe
msg241857 - (view) Author: Christian Heimes (christian.heimes) * (Python committer) Date: 2015-04-23 09:26
Thanks!
History
Date User Action Args
2015-04-23 09:26:32christian.heimessetstatus: open -> closed
resolution: fixed
messages: + msg241857

stage: commit review -> resolved
2015-04-23 09:26:09python-devsetnosy: + python-dev
messages: + msg241856
2015-04-23 03:59:05berker.peksagsetnosy: + berker.peksag

messages: + msg241840
stage: patch review -> commit review
2015-04-22 20:29:35christian.heimescreate