➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2015-03-13 15:31 by Vladimir Ulupov, last changed 2022-04-11 14:58 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| register_dialect_docstring_fix.patch | jbmilam, 2015-05-28 21:41 | Changes docstring of csv.register_dialect | review | |
| register_dialect_docstring_fix.patch | jbmilam, 2015-05-28 21:53 | Added end parentheses | review | |
| Messages (10) | |||
|---|---|---|---|
| msg238035 - (view) | Author: Vladimir Ulupov (Vladimir Ulupov) | Date: 2015-03-13 15:31 | |
I use PyCharm. This IDE checks the signature functions. When I used the extra arguments to the function register_dialect - IDE reported error. This is what has generated IDE for this function. http://dumpz.org/1347592/ Apparently error here https://hg.python.org/cpython/file/44c1c0cbdc06/Modules/_csv.c#l1547 https://hg.python.org/cpython/file/c1abcbcfefab/Modules/_csv.c#l1590 https://docs.python.org/2/library/csv.html?highlight=csv#csv.register_dialect https://docs.python.org/3/library/csv.html?highlight=csv#csv.register_dialect |
|||
| msg238036 - (view) | Author: R. David Murray (r.david.murray) *  |
Date: 2015-03-13 15:33 | |
Could you clarify what bug in python you are reporting? |
|||
| msg238081 - (view) | Author: Vladimir Ulupov (Vladimir Ulupov) | Date: 2015-03-14 12:17 | |
Incorrect docstring(PyDoc_STRVAR) for function csv.register_dialect |
|||
| msg238086 - (view) | Author: R. David Murray (r.david.murray) * |
Date: 2015-03-14 14:40 | |
Ah, you are trying to point out that the docstring doesn't mention fmtparams, or that the dialect object is optional. Sure, that should be fixed. |
|||
| msg238088 - (view) | Author: Vladimir Ulupov (Vladimir Ulupov) | Date: 2015-03-14 15:12 | |
Yes, sorry for my bad English. |
|||
| msg244348 - (view) | Author: Brandon Milam (jbmilam) * | Date: 2015-05-28 21:41 | |
I believe this was the requested change. Let me know if more was desired. |
|||
| msg244349 - (view) | Author: Brandon Milam (jbmilam) * | Date: 2015-05-28 21:53 | |
Sorry, I forgot an end parentheses in the doc string of the last patch. |
|||
| msg244376 - (view) | Author: Skip Montanaro (skip.montanaro) *  |
Date: 2015-05-29 13:43 | |
LGTM. |
|||
| msg244862 - (view) | Author: Roundup Robot (python-dev) |
Date: 2015-06-05 12:18 | |
New changeset 9377ffb9eaf2 by Berker Peksag in branch '3.4': Issue #23659: Document **fmtparams in csv.register_dialect docstring. https://hg.python.org/cpython/rev/9377ffb9eaf2 New changeset eee64e72d294 by Berker Peksag in branch '3.5': Issue #23659: Document **fmtparams in csv.register_dialect docstring. https://hg.python.org/cpython/rev/eee64e72d294 New changeset a3fbf1fe8fa6 by Berker Peksag in branch 'default': Issue #23659: Document **fmtparams in csv.register_dialect docstring. https://hg.python.org/cpython/rev/a3fbf1fe8fa6 |
|||
| msg244863 - (view) | Author: Berker Peksag (berker.peksag) * |
Date: 2015-06-05 12:19 | |
Thanks! |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:58:13 | admin | set | github: 67847 |
| 2015-06-05 12:19:52 | berker.peksag | set | status: open -> closed resolution: fixed messages: + msg244863 stage: patch review -> resolved |
| 2015-06-05 12:18:14 | python-dev | set | nosy:
+ python-dev messages: + msg244862 |
| 2015-05-29 13:43:03 | skip.montanaro | set | messages: + msg244376 |
| 2015-05-29 04:19:24 | berker.peksag | set | nosy:
+ berker.peksag stage: patch review versions: + Python 3.5, Python 3.6 |
| 2015-05-28 21:53:14 | jbmilam | set | files:
+ register_dialect_docstring_fix.patch messages: + msg244349 |
| 2015-05-28 21:41:54 | jbmilam | set | files:
+ register_dialect_docstring_fix.patch nosy: + jbmilam messages: + msg244348 keywords: + patch |
| 2015-03-14 15:12:56 | Vladimir Ulupov | set | messages: + msg238088 |
| 2015-03-14 14:40:12 | r.david.murray | set | messages: + msg238086 |
| 2015-03-14 12:17:48 | Vladimir Ulupov | set | messages: + msg238081 |
| 2015-03-13 15:37:39 | skip.montanaro | set | nosy:
+ skip.montanaro |
| 2015-03-13 15:33:12 | r.david.murray | set | nosy:
+ r.david.murray messages: + msg238036 |
| 2015-03-13 15:31:24 | Vladimir Ulupov | create | |