classification
Title: Deprecation warnings building 3.5 Visual Studio Windows 8.1 64 bit
Type: compile error Stage:
Components: Build, Windows Versions: Python 3.7
process
Status: open Resolution:
Dependencies: Superseder:
Assigned To: Nosy List: pitrou, python-dev, steve.dower, tim.golden, zach.ware
Priority: normal Keywords: patch

Created on 2015-02-11 23:34 by BreamoreBoy, last changed 2017-06-28 21:20 by steve.dower.

Files
File name Uploaded Description Edit
Deprecations.txt BreamoreBoy, 2015-02-11 23:34
23451_1.patch steve.dower, 2015-02-12 02:17 review
Pull Requests
URL Status Linked Edit
PR 2318 merged Segev Finer, 2017-06-21 21:58
Messages (10)
msg235778 - (view) Author: Mark Lawrence (BreamoreBoy) * Date: 2015-02-11 23:34
Raised as a placeholder.
msg235781 - (view) Author: Mark Lawrence (BreamoreBoy) * Date: 2015-02-11 23:40
Using Microsoft Visual Studio Express 2013 for Windows Desktop.
msg235786 - (view) Author: Steve Dower (steve.dower) * (Python committer) Date: 2015-02-12 01:24
Adding 'socket' nosy list, as Antoine may have a stronger opinion about changing _socket to avoid these warnings - they aren't all in Windows-exclusive code. Or I'm happy to add the suppression to the build if that's the better option.

I'll work up a patch for the GetVersion deprecations. I believe they're mostly checking for Vista, which we can assume now, so they aren't necessary.
msg235789 - (view) Author: Steve Dower (steve.dower) * (Python committer) Date: 2015-02-12 02:17
Patch attached.

Interesting, once you declare Vista as the minimum API set, WinSock claims to support CMSG_LEN which enables sendmsg() et al support in _socket. Since the WinSock API bears little relation to the POSIX(?) API, it doesn't build, so I've just undef'd CMSG_LEN when building socket.
msg236645 - (view) Author: Steve Dower (steve.dower) * (Python committer) Date: 2015-02-26 05:01
Anyone got a chance to double-check my patch for me? I think it's fine, unless someone really wants me to turn all the "#ifdef CMSG_LEN" checks into "#ifdef HAVE_CMSG" (which I *think* would require autoconf updates, which I am totally unqualified to do...)
msg237055 - (view) Author: Roundup Robot (python-dev) Date: 2015-03-02 16:01
New changeset 57e2549cc9a6 by Steve Dower in branch 'default':
Issue #23451: Update pyconfig.h for Windows to require Vista headers and remove unnecessary version checks.
https://hg.python.org/cpython/rev/57e2549cc9a6
msg237056 - (view) Author: Steve Dower (steve.dower) * (Python committer) Date: 2015-03-02 16:03
The _WINSOCK_DEPRECATED_NO_WARNINGS question is still open, but the rest of the deprecations should be clear now.
msg239401 - (view) Author: Roundup Robot (python-dev) Date: 2015-03-27 13:29
New changeset f64d0b99d405 by Victor Stinner in branch 'default':
Issue #23451, #22117: Python 3.5 now requires Windows Vista or newer, so
https://hg.python.org/cpython/rev/f64d0b99d405
msg297224 - (view) Author: Steve Dower (steve.dower) * (Python committer) Date: 2017-06-28 20:51
New changeset 9f3bdcb643623e07497af2fc35f0496c2302f1be by Steve Dower (Segev Finer) in branch 'master':
bpo-23451: Fix socket deprecation warnings in socketmodule.c (#2318)
https://github.com/python/cpython/commit/9f3bdcb643623e07497af2fc35f0496c2302f1be
msg297231 - (view) Author: Steve Dower (steve.dower) * (Python committer) Date: 2017-06-28 21:20
There is only one deprecation warning left in current builds:

..\Modules\expat\xmlparse.c(796): warning C4996: 'getenv': This function or variable may be unsafe. Consider using _dupenv_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details.
History
Date User Action Args
2017-06-28 21:20:09steve.dowersetmessages: + msg297231
versions: + Python 3.7, - Python 3.5
2017-06-28 20:51:02steve.dowersetmessages: + msg297224
2017-06-25 04:26:39zach.warelinkissue27523 superseder
2017-06-21 22:31:20BreamoreBoysetnosy: - BreamoreBoy
2017-06-21 21:58:31Segev Finersetpull_requests: + pull_request2368
2015-03-27 13:29:47python-devsetmessages: + msg239401
2015-03-02 16:03:13steve.dowersetmessages: + msg237056
2015-03-02 16:01:50python-devsetnosy: + python-dev
messages: + msg237055
2015-02-26 05:01:46steve.dowersetmessages: + msg236645
2015-02-12 02:17:08steve.dowersetfiles: + 23451_1.patch
keywords: + patch
messages: + msg235789
2015-02-12 01:24:13steve.dowersetnosy: + pitrou
messages: + msg235786
2015-02-11 23:41:00BreamoreBoysetmessages: + msg235781
2015-02-11 23:34:06BreamoreBoycreate