classification
Title: _ssl.c cannot be compiled with older versions of OpenSSL
Type: Stage: resolved
Components: Versions: Python 3.5, Python 2.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: Arfrever, benjamin.peterson, ned.deily, python-dev
Priority: critical Keywords:

Created on 2015-01-28 04:21 by ned.deily, last changed 2015-01-28 17:07 by python-dev. This issue is now closed.

Messages (2)
msg234871 - (view) Author: Ned Deily (ned.deily) * (Python committer) Date: 2015-01-28 04:21
_ssl.c compilation is broken on default and 27 when building with older (pre-1.0.1 ?) versions of OpenSSL:
  
/py/dev/3x/source/Modules/_ssl.c:2296:24: error: use of undeclared identifier
      'OPENSSL_NPN_NEGOTIATED'
    if (alpn && ret != OPENSSL_NPN_NEGOTIATED)

The code added by eaa38b75cc78 (default) and 94ec4d8cf104 (2.7) doesn't account for the possibility that NPN is not available.  (The Snow Leopard buildbots are down at the moment but I would expect them to be failing with this.)
msg234904 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2015-01-28 17:07
New changeset 16f982f93a47 by Benjamin Peterson in branch 'default':
ifdef our way to compatibility with old openssl (closes #23335)
https://hg.python.org/cpython/rev/16f982f93a47

New changeset 1addc4f0f10c by Benjamin Peterson in branch '2.7':
ifdef our way to compatibility with old openssl (closes #23335)
https://hg.python.org/cpython/rev/1addc4f0f10c
History
Date User Action Args
2015-01-28 17:07:23python-devsetstatus: open -> closed

nosy: + python-dev
messages: + msg234904

resolution: fixed
stage: needs patch -> resolved
2015-01-28 08:04:35Arfreversetnosy: + Arfrever
2015-01-28 04:21:26ned.deilycreate