This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: a mistype comment in PC/pyconfig.h
Type: enhancement Stage: resolved
Components: Windows Versions: Python 3.4, Python 3.5
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: zach.ware Nosy List: josephsmeng, python-dev, steve.dower, zach.ware
Priority: normal Keywords:

Created on 2014-06-11 01:37 by josephsmeng, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Messages (3)
msg220223 - (view) Author: Joseph Shen (josephsmeng) * Date: 2014-06-11 01:37
in the source file PC/pyconfig.h at line 393 there is a mistype

this is the origin file
==========================================================================
/* VC 7.1 has them and VC 6.0 does not.  VC 6.0 has a version number of 1200.
   Microsoft eMbedded Visual C++ 4.0 has a version number of 1201 and doesn't
   define these.
   If some compiler does not provide them, modify the #if appropriately. */
#if defined(_MSC_VER)
#if _MSC_VER > 1300
#define HAVE_UINTPTR_T 1
#define HAVE_INTPTR_T 1
#else
/* VC6, VS 2002 and eVC4 don't support the C99 LL suffix for 64-bit integer literals */
#define Py_LL(x) x##I64
#endif  /* _MSC_VER > 1200  */
#endif  /* _MSC_VER */

#endif

==========================================================================
>>> #endif /* _MSC_VER > 1200 */
should be
<<< #endif /* _MSC_VER > 1300 */
or left empty
msg220306 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2014-06-11 20:29
New changeset 61a00b7eac5d by Zachary Ware in branch '3.4':
Issue #21713: Fix typo in a comment.  Found by Joseph Shen.
http://hg.python.org/cpython/rev/61a00b7eac5d

New changeset b94384c4f9d0 by Zachary Ware in branch 'default':
Closes #21713: Merge with 3.4
http://hg.python.org/cpython/rev/b94384c4f9d0
msg220307 - (view) Author: Zachary Ware (zach.ware) * (Python committer) Date: 2014-06-11 20:30
Fixed, thanks for the report!
History
Date User Action Args
2022-04-11 14:58:04adminsetgithub: 65912
2014-06-11 20:31:13zach.waresetassignee: zach.ware
type: compile error -> enhancement
versions: + Python 3.4
2014-06-11 20:30:37zach.waresetmessages: + msg220307
2014-06-11 20:29:06python-devsetstatus: open -> closed

nosy: + python-dev
messages: + msg220306

resolution: fixed
stage: resolved
2014-06-11 02:28:08ned.deilysetnosy: + zach.ware, steve.dower
2014-06-11 01:37:15josephsmengcreate