classification
Title: Move test_namespace_pkgs into test_importlib.
Type: enhancement Stage: resolved
Components: Versions: Python 3.5, Python 3.4
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: barry, brett.cannon, eric.smith, eric.snow, ncoghlan, python-dev
Priority: low Keywords:

Created on 2014-03-29 21:21 by eric.snow, last changed 2014-04-09 01:57 by python-dev. This issue is now closed.

Messages (7)
msg215145 - (view) Author: Eric Snow (eric.snow) * (Python committer) Date: 2014-03-29 21:21
While working on #19711 it dawned on me that test_namespace_pkgs might be more appropriate as a submodule of test_importlib.  The feature doesn't have it's own module nor is it otherwise independent of importlib.

I don't want to introduce churn here for the sake of conceptual purity.  Rather, the module would be more discoverable if associated with importlib in this way.  For #19711 I wrote a test case that was overly complicated and did not work (goes hand-in-hand, no?) that I would not have spent time on if I'd remembered about test_namespace_pkgs or seen it somewhere under test_import*.

As a bonus, this change moves 1 file and 1 directory out of Lib/test (a directory that takes "flat is better than nested" to the extreme).

Any objections?
msg215149 - (view) Author: Nick Coghlan (ncoghlan) * (Python committer) Date: 2014-03-29 21:36
Fine by me.
msg215153 - (view) Author: Eric V. Smith (eric.smith) * (Python committer) Date: 2014-03-29 21:46
Makes sense to me.
msg215156 - (view) Author: Roundup Robot (python-dev) Date: 2014-03-29 22:08
New changeset 6d44bd8066ee by Eric Snow in branch 'default':
Issue #21097: Move test_namespace_pkgs into test_importlib.
http://hg.python.org/cpython/rev/6d44bd8066ee
msg215157 - (view) Author: Roundup Robot (python-dev) Date: 2014-03-29 22:15
New changeset 48790b202a50 by Eric Snow in branch '3.4':
Issue #21097: Move test_namespace_pkgs into test_importlib.
http://hg.python.org/cpython/rev/48790b202a50
msg215158 - (view) Author: Eric Snow (eric.snow) * (Python committer) Date: 2014-03-29 22:16
I seriously need to remember to apply to 3.4 and merge forward! :P
msg215795 - (view) Author: Roundup Robot (python-dev) Date: 2014-04-09 01:57
New changeset 99265d30fa38 by Ned Deily in branch '3.4':
Issue #21097: Update Makefile with changed install locations of test directories.
http://hg.python.org/cpython/rev/99265d30fa38

New changeset 7aae2b9fcfad by Ned Deily in branch 'default':
Issue #21097: merge from 3.4
http://hg.python.org/cpython/rev/7aae2b9fcfad
History
Date User Action Args
2014-04-09 01:57:35python-devsetmessages: + msg215795
2014-03-29 22:16:44eric.snowsetstatus: open -> closed
resolution: fixed
messages: + msg215158

stage: needs patch -> resolved
2014-03-29 22:15:22python-devsetmessages: + msg215157
2014-03-29 22:08:24python-devsetnosy: + python-dev
messages: + msg215156
2014-03-29 21:46:45eric.smithsetmessages: + msg215153
2014-03-29 21:36:20ncoghlansetmessages: + msg215149
2014-03-29 21:21:24eric.snowcreate