This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: test_poplib emits resource warning
Type: resource usage Stage: patch review
Components: email, Tests Versions: Python 3.4
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: barry, python-dev, r.david.murray, serhiy.storchaka, vajrasky, vstinner
Priority: normal Keywords: patch

Created on 2013-11-29 10:52 by vajrasky, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
fix_test_poplib_resource_warning.patch vajrasky, 2013-11-29 10:52 review
Messages (4)
msg204716 - (view) Author: Vajrasky Kok (vajrasky) * Date: 2013-11-29 10:52
$ ./python Lib/test/test_poplib.py
<omitted....>
test_uidl (__main__.TestPOP3_TLSClass) ... ok
test_user (__main__.TestPOP3_TLSClass) ... ok

----------------------------------------------------------------------
Ran 62 tests in 4.994s

OK
/home/ethan/Documents/code/python/cpython3.4/Lib/test/support/__init__.py:1331: ResourceWarning: unclosed <ssl.SSLSocket fd=5, family=AddressFamily.AF_INET, type=2049, proto=6, laddr=('127.0.0.1', 46785), raddr=('127.0.0.1', 55396)>
  gc.collect()


Attached the patch to fix the resource warning.
msg204802 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2013-11-30 11:13
See also http://permalink.gmane.org/gmane.comp.python.devel/143803 in which Victor had found a place of the leak.
msg205621 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2013-12-09 00:15
New changeset 1e3c7153a14d by Victor Stinner in branch 'default':
Fix #19830: Fix a ResourceWarning in test_poplib.
http://hg.python.org/cpython/rev/1e3c7153a14d
msg205622 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2013-12-09 00:15
The patch fixes the ResourceWarning, thanks.
History
Date User Action Args
2022-04-11 14:57:54adminsetgithub: 64029
2013-12-09 00:15:55vstinnersetstatus: open -> closed
resolution: fixed
messages: + msg205622
2013-12-09 00:15:32python-devsetnosy: + python-dev
messages: + msg205621
2013-12-08 16:22:54serhiy.storchakasetnosy: + vstinner

stage: patch review
2013-11-30 11:13:40serhiy.storchakasetnosy: + serhiy.storchaka
messages: + msg204802
2013-11-30 08:54:40r.david.murraysetnosy: + barry, r.david.murray
components: + email
2013-11-29 10:52:52vajraskycreate