classification
Title: Add tests for CLI of the tabnanny module
Type: enhancement Stage: patch review
Components: Tests Versions: Python 3.5
process
Status: open Resolution:
Dependencies: Superseder:
Assigned To: berker.peksag Nosy List: Al.Sweigart, berker.peksag, jaysinh.shukla, serhiy.storchaka, vstinner
Priority: low Keywords: patch

Created on 2013-09-27 11:41 by berker.peksag, last changed 2018-06-15 04:34 by jaysinh.shukla.

Files
File name Uploaded Description Edit
test_tabnanny.diff berker.peksag, 2013-09-27 11:41 review
Pull Requests
URL Status Linked Edit
PR 7699 open jaysinh.shukla, 2018-06-15 04:33
Messages (6)
msg198467 - (view) Author: Berker Peksag (berker.peksag) * (Python committer) Date: 2013-09-27 11:41
I was trying to use the argparse module instead of getopt and I couldn't find any tests for CLI of the tabnanny module.
msg230733 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2014-11-06 10:14
Added comments on Rietveld.

Although tabnanny is located in the Lib directory, not in the Tools directory, technically it is a script. May be move test_tabnanny.py to Lib/test/test_tools?
msg233642 - (view) Author: Al Sweigart (Al.Sweigart) * Date: 2015-01-08 11:04
Since tabnanny is also a module in the standard library (it is imported by the idle code), wouldn't moving it to lib/test/test_tools make it un-importable? This would be a good case for leaving it where it is.
msg319502 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2018-06-14 07:35
New changeset dfa9643d292dcaa14cbf3c44b8330ba2159976c0 by Victor Stinner (Jaysinh Shukla) in branch 'master':
bpo-19382: Adding test cases for module tabnanny (GH-851)
https://github.com/python/cpython/commit/dfa9643d292dcaa14cbf3c44b8330ba2159976c0

--

@Jaysinh Shukla: I looked at Berker's old patch, and I think that it would be interesting to modify tabnanny to return with a non-zero exit code in case of failure. Maybe replace "return" with "sys.exit(1)" after errprint() calls.
msg319503 - (view) Author: Jaysinh shukla (jaysinh.shukla) * Date: 2018-06-14 07:56
@STINNER Victor Thanks for merging. I will try to observe that patch and will update you here. Have a great day
msg319584 - (view) Author: Jaysinh shukla (jaysinh.shukla) * Date: 2018-06-15 04:34
@vstinner I have created the PR here. I wasn't sure so linked the PR with this issue. Thanks!

PR URL: https://github.com/python/cpython/pull/7699
History
Date User Action Args
2018-06-15 04:34:31jaysinh.shuklasetmessages: + msg319584
2018-06-15 04:33:10jaysinh.shuklasetpull_requests: + pull_request7315
2018-06-14 07:56:13jaysinh.shuklasetmessages: + msg319503
2018-06-14 07:35:04vstinnersetnosy: + vstinner, jaysinh.shukla
messages: + msg319502
2015-01-08 11:04:32Al.Sweigartsetnosy: + Al.Sweigart
messages: + msg233642
2014-11-06 10:14:21serhiy.storchakasetversions: + Python 3.5, - Python 3.4
nosy: + serhiy.storchaka

messages: + msg230733

assignee: berker.peksag
type: enhancement
2013-09-27 11:41:08berker.peksagcreate