This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: tabnanny unit tests
Type: enhancement Stage: resolved
Components: Tests Versions: Python 3.8
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: Colin.Williams, berker.peksag, ezio.melotti, vstinner
Priority: normal Keywords: patch

Created on 2013-10-24 22:58 by Colin.Williams, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
tabnanny.patch Colin.Williams, 2013-10-24 22:58 review
Pull Requests
URL Status Linked Edit
PR 851 merged jaysinh.shukla, 2017-03-27 17:19
Messages (6)
msg201194 - (view) Author: Colin Williams (Colin.Williams) Date: 2013-10-24 22:58
I didn't test the stdout and stderr stuff, but I got the module up to 74% coverage.
msg201195 - (view) Author: Berker Peksag (berker.peksag) * (Python committer) Date: 2013-10-24 23:19
See also issue 19102.
msg201196 - (view) Author: Colin Williams (Colin.Williams) Date: 2013-10-24 23:28
Alright, I'll wait until that one gets committed, and then add in my changes.  I think between the two of us we'll get close to 100%
msg203108 - (view) Author: Ezio Melotti (ezio.melotti) * (Python committer) Date: 2013-11-16 23:50
I left a few comments on rietveld.
msg319498 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2018-06-14 07:05
New changeset dfa9643d292dcaa14cbf3c44b8330ba2159976c0 by Victor Stinner (Jaysinh Shukla) in branch 'master':
bpo-19382: Adding test cases for module tabnanny (GH-851)
https://github.com/python/cpython/commit/dfa9643d292dcaa14cbf3c44b8330ba2159976c0
msg319500 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2018-06-14 07:09
Thanks Jaysinh Shukla for adding new unit tests to tabnanny, good job!

I don't think that it's worth it to backport the new tests to 2.7, 3.6 or 3.7 branch.
History
Date User Action Args
2022-04-11 14:57:52adminsetgithub: 63581
2018-06-14 07:09:42vstinnersetstatus: open -> closed
versions: + Python 3.8, - Python 3.4
messages: + msg319500

resolution: fixed
stage: patch review -> resolved
2018-06-14 07:05:39vstinnersetnosy: + vstinner
messages: + msg319498
2017-03-27 17:19:40jaysinh.shuklasetpull_requests: + pull_request751
2013-11-16 23:50:47ezio.melottisettype: enhancement

messages: + msg203108
nosy: + ezio.melotti
2013-10-24 23:28:42Colin.Williamssetmessages: + msg201196
2013-10-24 23:19:09berker.peksagsetversions: + Python 3.4
nosy: + berker.peksag

messages: + msg201195

components: + Tests
stage: patch review
2013-10-24 22:58:45Colin.Williamscreate