classification
Title: There is still last bit of GNU Pth code in signalmodule.c
Type: Stage:
Components: Extension Modules Versions: Python 3.4
process
Status: open Resolution:
Dependencies: Superseder:
Assigned To: Nosy List: christian.heimes, jcea, python-dev, vajrasky
Priority: normal Keywords: patch

Created on 2013-08-18 04:58 by vajrasky, last changed 2013-08-23 19:01 by ezio.melotti.

Files
File name Uploaded Description Edit
remove_gnu_pth.patch vajrasky, 2013-08-18 04:58 review
Messages (3)
msg195542 - (view) Author: Vajrasky Kok (vajrasky) * Date: 2013-08-18 04:58
I read this commit:
http://hg.python.org/cpython/rev/1d5f644b9241

But I noticed there is still GNU Pth code lingering around in Modules/signalmodule.c.

Beside of that the WITH_PTH code (in the same file) is expired already. If you configure python with this option (--with-pth), the configure process will complain that it does not recognize the option.

Attached the patch to clean up this last bit of GNU Pth code.
msg195552 - (view) Author: Roundup Robot (python-dev) Date: 2013-08-18 10:43
New changeset 646c2388d8f5 by Christian Heimes in branch 'default':
Issue #18774: Remove last bits of GNU PTH thread code, patch by Vajrasky Kok.
http://hg.python.org/cpython/rev/646c2388d8f5
msg195554 - (view) Author: Christian Heimes (christian.heimes) * (Python committer) Date: 2013-08-18 12:02
Thanks! Three comments still refer to GNU pth:

configure.ac:    # (e.g. gnu pth with pthread emulation)
Python/condvar.h:   library (e.g. gnu pth in pthread emulation) */
Python/thread.c:   library (e.g. gnu pth in pthread emulation) */

thread.c and condvar.h implement a fallback for libraries that don't provide _POSIX_THREADS.
History
Date User Action Args
2013-08-23 19:01:42ezio.melottisetmessages: - msg195643
2013-08-19 16:12:28python-devsetmessages: + msg195643
2013-08-19 05:47:47jceasetnosy: + jcea
2013-08-18 12:02:06christian.heimessetmessages: + msg195554
2013-08-18 10:43:32python-devsetnosy: + python-dev
messages: + msg195552
2013-08-18 04:58:00vajraskycreate