classification
Title: test_stat nits
Type: behavior Stage: resolved
Components: Tests Versions: Python 3.4
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: christian.heimes Nosy List: christian.heimes, pitrou, python-dev, serhiy.storchaka, terry.reedy, vstinner, zach.ware
Priority: normal Keywords: patch

Created on 2013-06-28 09:54 by pitrou, last changed 2013-06-29 10:59 by pitrou. This issue is now closed.

Files
File name Uploaded Description Edit
test_stat.patch pitrou, 2013-06-28 09:54 review
Messages (8)
msg191985 - (view) Author: Antoine Pitrou (pitrou) * (Python committer) Date: 2013-06-28 09:54
Patch with small fixes and improvements to test_stat.
msg191996 - (view) Author: Christian Heimes (christian.heimes) * (Python committer) Date: 2013-06-28 15:14
I wish the loader would ignore all test classes with a leading underscore or would gain another way to mark a test class as abstract. The mixin approach looks ugly and prohibits tab completion in my IDE.
msg192001 - (view) Author: Antoine Pitrou (pitrou) * (Python committer) Date: 2013-06-28 15:42
> I wish the loader would ignore all test classes with a leading
> underscore or would gain another way to mark a test class as
> abstract. The mixin approach looks ugly and prohibits tab completion
> in my IDE.

I don't really understand what makes mixins "ugly". I'm sorry about
your IDE :-)
msg192004 - (view) Author: Christian Heimes (christian.heimes) * (Python committer) Date: 2013-06-28 16:44
Ask your Java buddies about mixins. :)

Go ahead and submit the patch.
msg192016 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2013-06-28 20:00
While you are at it, should you just replace test_main with unittest.main?
msg192017 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2013-06-28 20:15
> The mixin approach looks ugly and prohibits tab completion in my IDE.

It is a common practice in Python, especially in tests.
msg192031 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2013-06-29 10:59
New changeset f3f38c84aebc by Antoine Pitrou in branch 'default':
Issue #18322: fix some test_stat nits.
http://hg.python.org/cpython/rev/f3f38c84aebc
msg192032 - (view) Author: Antoine Pitrou (pitrou) * (Python committer) Date: 2013-06-29 10:59
Committed with unittest.main(). Thanks for the comments.
History
Date User Action Args
2013-06-29 10:59:27pitrousetstatus: open -> closed
resolution: fixed
messages: + msg192032

stage: patch review -> resolved
2013-06-29 10:59:05python-devsetnosy: + python-dev
messages: + msg192031
2013-06-28 20:15:49vstinnersetnosy: + vstinner
messages: + msg192017
2013-06-28 20:00:30terry.reedysetnosy: + terry.reedy
messages: + msg192016
2013-06-28 19:30:00serhiy.storchakasetnosy: + zach.ware
2013-06-28 19:28:14serhiy.storchakasetnosy: + serhiy.storchaka
2013-06-28 16:44:06christian.heimessetmessages: + msg192004
2013-06-28 15:42:55pitrousetmessages: + msg192001
2013-06-28 15:14:48christian.heimessetmessages: + msg191996
2013-06-28 09:54:55pitroucreate