classification
Title: Fix the name of _PyObject_CallMethodObjIdArgs
Type: behavior Stage: resolved
Components: Interpreter Core Versions: Python 3.4
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: alexandre.vassalotti Nosy List: alexandre.vassalotti, brett.cannon, loewis, python-dev
Priority: normal Keywords: patch

Created on 2013-05-02 08:45 by alexandre.vassalotti, last changed 2013-05-02 17:44 by python-dev. This issue is now closed.

Files
File name Uploaded Description Edit
rename_PyObject_CallMethodIdObjArgs.patch alexandre.vassalotti, 2013-05-02 08:45 review
Messages (3)
msg188257 - (view) Author: Alexandre Vassalotti (alexandre.vassalotti) * (Python committer) Date: 2013-05-02 08:45
The changeset 2dd046be2c88 introduced _PyObject_CallMethodObjIdArgs. This API should have been named _PyObject_CallMethodIdObjArgs since it is the variant of _PyObject_CallMethodId which takes object arguments instead of building arguments from a format string.

I would fix it myself. However, I am not sure how we should proceed with regard to backward incompatibility.
msg188266 - (view) Author: Brett Cannon (brett.cannon) * (Python committer) Date: 2013-05-02 13:28
It has a leading underscore for a reason; there is no backwards-compatibility guarantee as it's private to CPython internals. Refactor to your heart's content.
msg188279 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2013-05-02 17:44
New changeset 8a364deb0225 by Alexandre Vassalotti in branch 'default':
Closes #17892: Fix the name of _PyObject_CallMethodObjIdArgs
http://hg.python.org/cpython/rev/8a364deb0225
History
Date User Action Args
2013-05-02 17:44:25python-devsetstatus: open -> closed

nosy: + python-dev
messages: + msg188279

resolution: fixed
stage: patch review -> resolved
2013-05-02 13:28:16brett.cannonsetassignee: brett.cannon -> alexandre.vassalotti
2013-05-02 13:28:09brett.cannonsetmessages: + msg188266
2013-05-02 08:49:34vstinnersetnosy: + loewis
2013-05-02 08:45:28alexandre.vassalotticreate