The zipfile.testzip() method will open each of the files in a zip archive, but does not close the files, resulting in a file descriptor leak.

I've tried just closing the ZipExtFile created in testzip, but that didn't actually close the file. It looks like ZipExtClose.close() also doesn't close the file descriptor, at least when the ZipFile is constructed on a filename.

This code worked (Addition of f._fileobj.close() )

f = zf.open(zinfo.filename, "r")
while f.read( 2 ** 20):     # Check CRC-32
  pass
f.close()
f._fileobj.close() # This shoulnd't be necessary, but it is.

Quite the contrary.  The ZipExtFile closes the file descriptor if the ZipFile is constructed on a filename.

I think this is a duplicate of issue #16183. Are you sure python 3 is affected?.

No, this is not a duplicate.  ZipExtFile.close() closes a file handle, but ZipExtFile.close() is not used here.  I see also some possible FD leaks in ZipFile.open().  It will be good to fix all them in this issue.  If no one will make a patch for this easy issue, I'll do it.

Serhiy Storchaka, go for it.

Here is a patch.  In additional to leaks in testzip and ZipFile.open() I fixed possible leaks in other places.

New changeset d51d95c9ea81 by Antoine Pitrou in branch '3.2':
Issue #16408: Fix file descriptors not being closed in error conditions in the zipfile module.
http://hg.python.org/cpython/rev/d51d95c9ea81

New changeset 27cb1a3d57c8 by Antoine Pitrou in branch '3.3':
Issue #16408: Fix file descriptors not being closed in error conditions in the zipfile module.
http://hg.python.org/cpython/rev/27cb1a3d57c8

New changeset 779e8f31dd30 by Antoine Pitrou in branch 'default':
Issue #16408: Fix file descriptors not being closed in error conditions in the zipfile module.
http://hg.python.org/cpython/rev/779e8f31dd30

New changeset eba28506eed3 by Antoine Pitrou in branch '2.7':
Issue #16408: Fix file descriptors not being closed in error conditions in the zipfile module.
http://hg.python.org/cpython/rev/eba28506eed3

Thank you for the patches. They looked fine, so I committed them.