classification
Title: memory leaks in selectmodule.c
Type: resource usage Stage: resolved
Components: Versions: Python 3.2, Python 3.3
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: jcea, jll, python-dev
Priority: normal Keywords: patch

Created on 2012-07-19 14:08 by jll, last changed 2012-07-19 19:33 by python-dev. This issue is now closed.

Files
File name Uploaded Description Edit
selectmodule.patch jll, 2012-07-19 14:08 patch for selectmodule.c review
Messages (2)
msg165840 - (view) Author: Julia Lawall (jll) * Date: 2012-07-19 14:08
In Modules/selectmodule.c, in the function seq2set, fast_seq should be decrefd on failure of the initialization of o.  This will make a useless call to DECREF on o, but XDECREF is already used, so it is safe in the NULL case.

In the same file, in the function poll_modify, key should be decrefed on all execution paths that lead out of the function.
msg165867 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2012-07-19 19:33
New changeset bc9b2956bb8b by Jesus Cea in branch '3.2':
Closes #15395: memory leaks in selectmodule.c
http://hg.python.org/cpython/rev/bc9b2956bb8b

New changeset 9985b4651436 by Jesus Cea in branch 'default':
MERGE: Closes #15395: memory leaks in selectmodule.c
http://hg.python.org/cpython/rev/9985b4651436
History
Date User Action Args
2012-07-19 19:33:20python-devsetstatus: open -> closed

nosy: + python-dev
messages: + msg165867

resolution: fixed
stage: resolved
2012-07-19 19:29:19jceasetnosy: + jcea

versions: + Python 3.3
2012-07-19 14:08:34jllcreate