➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2012-04-04 12:10 by Claudiu.Popa, last changed 2022-04-11 14:57 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| pdeps.patch | Claudiu.Popa, 2012-04-04 12:10 | |||
| pdeps2.patch | Claudiu.Popa, 2012-04-05 07:23 | review | ||
| Messages (6) | |||
|---|---|---|---|
| msg157471 - (view) | Author: PCManticore (Claudiu.Popa) *  |
Date: 2012-04-04 12:10 | |
Tools/pdeps.py is using has_key for a dictionary. The attached patch fixes this issue. |
|||
| msg157528 - (view) | Author: R. David Murray (r.david.murray) *  |
Date: 2012-04-05 01:33 | |
This one is not a syntax error, so the new 'sundry' tests don't catch it. Want to write a test for this one? |
|||
| msg157540 - (view) | Author: Georg Brandl (georg.brandl) * |
Date: 2012-04-05 06:55 | |
Should be "x not in y" BTW to be idiomatic, not "not x in y". |
|||
| msg157546 - (view) | Author: PCManticore (Claudiu.Popa) * |
Date: 2012-04-05 07:23 | |
Hello. Here is the new patch. There was a few more problems: 1. in process, fp wasn't closed 2. in process, m_import.match(line) >= 0 could fail if the regular expression didn't matched on that line I've included the tests, too. |
|||
| msg157640 - (view) | Author: Roundup Robot (python-dev) |
Date: 2012-04-06 03:01 | |
New changeset e9b8115c5b25 by R David Murray in branch '3.2': #14492: fix some bugs in Tools/scripts/pdeps.py. http://hg.python.org/cpython/rev/e9b8115c5b25 New changeset 26a7cc129b3d by R David Murray in branch 'default': Merge #14492: fix some bugs in Tools/scripts/pdeps.py. http://hg.python.org/cpython/rev/26a7cc129b3d |
|||
| msg157641 - (view) | Author: R. David Murray (r.david.murray) * |
Date: 2012-04-06 03:05 | |
Thanks, Popa. I made some style changes to the tests, but otherwise used your patch. One small note: your might want to see about setting your editor to show whitespace at the ends of lines, or use the 'make patchcheck' command to check for whitespace. Our commit hooks reject files that have lines with trailing whitespace, since it tends to clutter up diffs. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:57:28 | admin | set | github: 58697 |
| 2017-12-11 16:43:09 | cheryl.sabella | link | issue11123 superseder |
| 2012-04-06 03:05:17 | r.david.murray | set | status: open -> closed resolution: fixed messages: + msg157641 stage: test needed -> resolved |
| 2012-04-06 03:01:29 | python-dev | set | nosy:
+ python-dev messages: + msg157640 |
| 2012-04-05 07:23:42 | Claudiu.Popa | set | files:
+ pdeps2.patch messages: + msg157546 |
| 2012-04-05 06:55:11 | georg.brandl | set | nosy:
+ georg.brandl messages: + msg157540 |
| 2012-04-05 01:33:22 | r.david.murray | set | nosy:
+ r.david.murray messages: + msg157528 |
| 2012-04-04 14:28:11 | r.david.murray | set | type: behavior stage: test needed |
| 2012-04-04 12:10:33 | Claudiu.Popa | set | components:
+ Demos and Tools versions: + Python 3.2, Python 3.3 |
| 2012-04-04 12:10:21 | Claudiu.Popa | create | |