classification
Title: tarfile.extractall fails to overwrite unresolved symlinks and hard links
Type: behavior Stage: resolved
Components: Library (Lib) Versions: Python 2.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: orsenthil Nosy List: Scott.Leerssen, orsenthil, python-dev
Priority: normal Keywords:

Created on 2011-05-16 14:01 by Scott.Leerssen, last changed 2011-05-17 02:16 by orsenthil. This issue is now closed.

Messages (4)
msg136091 - (view) Author: Scott Leerssen (Scott.Leerssen) Date: 2011-05-16 14:01
I'm opening this as a continuation of issue10761 since it was closed as fixed, and there's a bit more work to do there.

The fix for issue10761 was incomplete.  It did not handle the case where the symlink being overwritten did not resolve to another file (i.e. a "broken" link).  It also did not address the same issues with hard links.

The comments starting at http://bugs.python.org/issue10761#msg135924 detail the updates needed to complete this fix.
msg136093 - (view) Author: Senthil Kumaran (orsenthil) * (Python committer) Date: 2011-05-16 14:22
I looked at your message and the patch, seems okay for the case of testing if the symlink is broken and performing the next steps. I shall commit it soon.
msg136134 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2011-05-17 02:14
New changeset b29f0b6fcb76 by Senthil Kumaran in branch '2.7':
Fix closes issue #12088 - fixes the tarfile.extractall  issue when the
http://hg.python.org/cpython/rev/b29f0b6fcb76
msg136135 - (view) Author: Senthil Kumaran (orsenthil) * (Python committer) Date: 2011-05-17 02:16
Committed the fix. Thank you, Scott.
History
Date User Action Args
2011-05-17 02:16:01orsenthilsetstatus: open -> closed
resolution: fixed
messages: + msg136135

stage: resolved
2011-05-17 02:14:35python-devsetnosy: + python-dev
messages: + msg136134
2011-05-16 14:22:44orsenthilsetassignee: orsenthil

messages: + msg136093
nosy: + orsenthil
2011-05-16 14:01:04Scott.Leerssencreate