On Tue, Sep 9, 2008 at 3:00 PM, Vinay Sajip <report@bugs.python.org> wrote:
>
> Vinay Sajip <vinay_sajip@yahoo.co.uk> added the comment:
>
> Sorry, no - whoops. It was a minor test data change which introduced the
> problem...I didn't think it was worth wasting anyone's time (I ran
> regrtest, which passed, before checkin) but if you tell me that *all*
> changes need to be reviewed,

All changes are supposed to happen with the thinking that something
like this wouldn't slip through.

> I'll make sure this gets done.

Well, I am not going to make you revert it, just make sure that future
patches you want in during the rc phase get reviewed.

> I had
> thought that only changes of a certain size/complexity needed review...
>
> Is it OK to assign my changes to you for review?

I don't necessarily have the time, so don't assign to me. Setting
"needs review" and making it a release blocker should be enough to get
someone to look it over.

-Brett