➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2008-09-09 01:56 by brett.cannon, last changed 2022-04-11 14:56 by admin. This issue is now closed.
| Messages (5) | |||
|---|---|---|---|
| msg72818 - (view) | Author: Brett Cannon (brett.cannon) *  |
Date: 2008-09-09 01:56 | |
test_logging is leaving behind a file named 'test.blah' after every run. |
|||
| msg72858 - (view) | Author: Vinay Sajip (vinay.sajip) * |
Date: 2008-09-09 13:43 | |
Fix checked into trunk - revision 66337. |
|||
| msg72901 - (view) | Author: Brett Cannon (brett.cannon) * |
Date: 2008-09-09 19:39 | |
On Tue, Sep 9, 2008 at 6:43 AM, Vinay Sajip <report@bugs.python.org> wrote: > > Vinay Sajip <vinay_sajip@yahoo.co.uk> added the comment: > > Fix checked into trunk - revision 66337. > Did anyone do a code review for this? |
|||
| msg72923 - (view) | Author: Vinay Sajip (vinay.sajip) * |
Date: 2008-09-09 22:00 | |
Sorry, no - whoops. It was a minor test data change which introduced the problem...I didn't think it was worth wasting anyone's time (I ran regrtest, which passed, before checkin) but if you tell me that *all* changes need to be reviewed, I'll make sure this gets done. I had thought that only changes of a certain size/complexity needed review... Is it OK to assign my changes to you for review? |
|||
| msg72936 - (view) | Author: Brett Cannon (brett.cannon) * |
Date: 2008-09-10 02:33 | |
On Tue, Sep 9, 2008 at 3:00 PM, Vinay Sajip <report@bugs.python.org> wrote: > > Vinay Sajip <vinay_sajip@yahoo.co.uk> added the comment: > > Sorry, no - whoops. It was a minor test data change which introduced the > problem...I didn't think it was worth wasting anyone's time (I ran > regrtest, which passed, before checkin) but if you tell me that *all* > changes need to be reviewed, All changes are supposed to happen with the thinking that something like this wouldn't slip through. > I'll make sure this gets done. Well, I am not going to make you revert it, just make sure that future patches you want in during the rc phase get reviewed. > I had > thought that only changes of a certain size/complexity needed review... > > Is it OK to assign my changes to you for review? I don't necessarily have the time, so don't assign to me. Setting "needs review" and making it a release blocker should be enough to get someone to look it over. -Brett |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:56:38 | admin | set | nosy:
+ barry github: 48059 |
| 2008-09-10 02:33:15 | brett.cannon | set | messages: + msg72936 |
| 2008-09-09 22:00:46 | vinay.sajip | set | messages: + msg72923 |
| 2008-09-09 19:39:42 | brett.cannon | set | messages: + msg72901 |
| 2008-09-09 13:43:55 | vinay.sajip | set | status: open -> closed resolution: fixed messages: + msg72858 |
| 2008-09-09 13:14:50 | barry | set | priority: deferred blocker -> release blocker |
| 2008-09-09 01:56:06 | brett.cannon | create | |